Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make scanlines and grille non-destructive #5

Closed
wants to merge 1 commit into from
Closed

Make scanlines and grille non-destructive #5

wants to merge 1 commit into from

Conversation

Miltage
Copy link

@Miltage Miltage commented Oct 4, 2020

Simple adjustment, but this allows the developer to lower the opacity of the scanlines and grille without resulting in a completely black screen, which is exactly what I needed for Bodge Dall!

https://www.reddit.com/r/godot/comments/j0yk4r/spent_the_weekend_building_this_arcadestyle/g7ho26u/

@Miltage
Copy link
Author

Miltage commented Oct 19, 2020

@hiulit Just a reminder about this outstanding PR.

@hiulit
Copy link
Owner

hiulit commented Oct 19, 2020

Thanks! I'm sorry for the the late reply, I didn't see it.
I'm just about to release v2.0.0 and I changed how the scan lines behave so there's no need for this there, but I'll fix in v1.4.0 ;)

@hiulit
Copy link
Owner

hiulit commented Oct 20, 2020

Here is the new v1.3.1 with your fix ;)

Thanks for the contribution!

BTW, I've just released v2.0.0, if you want to check it out.

@hiulit hiulit closed this Oct 20, 2020
@Miltage
Copy link
Author

Miltage commented Oct 20, 2020

In all my years on Github this was my first contribution. Very cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants