Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MetadataCombiner, partitial refactoring on Metadata #96

Merged
merged 13 commits into from
Jan 3, 2024

Conversation

Wh1isper
Copy link
Collaborator

@Wh1isper Wh1isper commented Jan 2, 2024

Description

Motivation and Context

  • Rename tests/metadata to tests/data_models
  • Intro RelationshipInspector for building relations.
  • MetadataCombiner framework
  • Added generic interface to Metadata

How has this been tested?

Types of changes

  • Maintenance (no change in code, maintain the project's CI, docs, etc.)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Contributor

sweep-ai bot commented Jan 2, 2024

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2024

Codecov Report

Attention: 60 lines in your changes are missing coverage. Please review.

Comparison is base (00ba7f1) 75.68% compared to head (2596997) 76.63%.

Files Patch % Lines
sdgx/data_models/combiner.py 51.51% 48 Missing ⚠️
sdgx/data_models/metadata.py 81.81% 12 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
+ Coverage   75.68%   76.63%   +0.95%     
==========================================
  Files          58       59       +1     
  Lines        2274     2435     +161     
==========================================
+ Hits         1721     1866     +145     
- Misses        553      569      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wh1isper Wh1isper marked this pull request as ready for review January 3, 2024 08:30
@Wh1isper
Copy link
Collaborator Author

Wh1isper commented Jan 3, 2024

Still remaning work:

  • Adding mock data for multiple tables
  • Adding unit tests for MetadataCombiner.

@Wh1isper Wh1isper requested a review from MooooCat January 3, 2024 08:32
@Wh1isper Wh1isper changed the title Implement MetadataCombiner Implement MetadataCombiner, partitial refactoring on Metadata Jan 3, 2024
Copy link
Contributor

@MooooCat MooooCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

(Maybe we should add more demo data for multi-table scenario, I can start a issue and work on it.)

@MooooCat MooooCat merged commit 160f6a2 into main Jan 3, 2024
11 checks passed
@Wh1isper
Copy link
Collaborator Author

Wh1isper commented Jan 3, 2024

Maybe we should add more demo data for multi-table scenario, I can start a issue and work on it.

I'll be introducing some very simple mock data to use as unit tests, @MooooCat please help us gather some real multi-table scenario data to introduce into the project, like the current adult.csv.

@Wh1isper Wh1isper deleted the feature-named-metadata branch January 3, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants