Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check the type of foreign key #229

Merged
merged 7 commits into from
Nov 4, 2024
Merged

Conversation

Z712023
Copy link
Collaborator

@Z712023 Z712023 commented Nov 2, 2024

Description

check the type of foreign key in parent/child table

Motivation and Context

The data types of foreign keys need to be consistent.
And they should be id_columns.

How has this been tested?

Modify test_relationship.py and add some specific test cases

Types of changes

  • Maintenance (no change in code, maintain the project's CI, docs, etc.)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@hitsz-ids hitsz-ids deleted a comment from sweep-ai bot Nov 2, 2024

This comment was marked as abuse.

Copy link
Collaborator

@jalr4ever jalr4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is not yet streamlined enough, but it does not affect the main logic and can be merged.

@jalr4ever
Copy link
Collaborator

The ISSUE associated with this PR should be: #110

@jalr4ever jalr4ever merged commit ac2a824 into main Nov 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants