Fix precision problem in metric's testcases #185
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The changes in this PR aim to address the issue of Python's floating-point precision causing test failures. This PR sets an absolute tolerance of 1e-9 using the
np.isclose
function.Motivation and Context
The original test cases were failing due to Python's floating-point precision issues. This was causing the test cases to fail even though the results were theoretically correct.
By introducing absolute tolerances, we can make the test cases more robust and less likely to fail due to floating-point precision issues.
How has this been tested?
The changes have been tested using testing cases.
Types of changes
Checklist: