Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: fix KeyError when metadata raising an MetadataInvalidError. #134

Merged
merged 2 commits into from
Feb 4, 2024

Conversation

MooooCat
Copy link
Contributor

@MooooCat MooooCat commented Feb 4, 2024

Description

Motivation and Context

How has this been tested?

Types of changes

  • Maintenance (no change in code, maintain the project's CI, docs, etc.)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ff2022b) 80.26% compared to head (3535fb9) 80.26%.

Files Patch % Lines
sdgx/data_models/metadata.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #134   +/-   ##
=======================================
  Coverage   80.26%   80.26%           
=======================================
  Files          66       66           
  Lines        2975     2975           
=======================================
  Hits         2388     2388           
  Misses        587      587           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MooooCat MooooCat marked this pull request as ready for review February 4, 2024 09:18
@MooooCat MooooCat merged commit 782bcfe into main Feb 4, 2024
11 checks passed
@MooooCat MooooCat deleted the bugfix-fix-metadata-check-bug branch February 4, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants