Send abo magazin confirmation email (#1129) #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaierhofer
force-pushed
the
feature/1129-abo-magazin-confirmation-mailer
branch
from
7123bbf
to
846353e
Compare
5 tasks
codez
approved these changes
Nov 6, 2024
| end | ||
|
|
||
| def placeholder_language | ||
| Event::Course.language_labels.stringify_keys[@person.language] |
There was a problem hiding this comment.
Das sollte wohl nicht vom Kurs kommen, eher von der Person. (Auch wenn die Werte jetzt gleich sein mögen, sind die unabhängig voneinander).
There was a problem hiding this comment.
ja, das macht viel mehr Sinn, hab ich angepasst.
| magazin: [ | ||
| AboCost.new(amount: 60, country: :switzerland), | ||
| AboCost.new(amount: 76, country: :international) | ||
| ], |
There was a problem hiding this comment.
Anstelle eines Arrays wäre ein Hash mit dem country als Key effizienter. Dann braucht es im aufrufenden Code kein find, es kann direkt mit [country] auf den richtigen Wert zugegriffen werden.
There was a problem hiding this comment.
Ist nicht ganz so easy umzusetzen (locales, fallback für die verschiedenen internationalen Länder, partial wird auch von einem Abo ohne country verwendet), ich lasse das vorerst so
amaierhofer
force-pushed
the
feature/1129-abo-magazin-confirmation-mailer
branch
from
a1f49d5
to
a73d345
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.