Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/movies db #260

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

m-shahzab
Copy link

This pull request introduces new routes and controllers for handling movies and series data. The most important changes include adding new routes for movies and series, creating controllers to manage these routes, and updating the main application file to include the new routes.

New Routes and Controllers:

  • Movies Routes and Controllers:

  • Series Routes and Controllers:

Copy link
Collaborator

@wajeshubham wajeshubham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the swagger.yaml file and include these apis in public api section


const getMovies = asyncHandler(async (req, res) => {
const page = +(req.query.page || 1);
const limit = +(req.query.limit || 10);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add more query parameters to make this api more dynamic. refer:

const getBooks = asyncHandler(async (req, res) => {

const getSeries = asyncHandler(async (req, res) => {
const page = +(req.query.page || 1);
const limit = +(req.query.limit || 10);
const paginatedMovies = getPaginatedPayload(seriesJson, page, limit);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add more query parameters to make this api more dynamic. refer:

const getBooks = asyncHandler(async (req, res) => {

src/routes/public/movies.routes.js Show resolved Hide resolved
src/routes/public/series.routes.js Show resolved Hide resolved
@m-shahzab m-shahzab requested a review from wajeshubham November 2, 2024 10:35
@m-shahzab
Copy link
Author

@wajeshubham

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants