add helm to k8s master for vault and fixes [#1729] #1731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erzetpe
approved these changes
Oct 2, 2020
|
LGTM, tested |
rpudlowski93
approved these changes
Oct 2, 2020
sk4zuzu
suggested changes
Oct 2, 2020
| when: | ||
| - specification.vault_enabled | ||
| - k8s_as_cloud_service is not defined |
There was a problem hiding this comment.
I think this line has no effect, we can safely assume this is defined always (it's merged with defaults), no? 🤔
Suggested change
| - k8s_as_cloud_service is not defined |
There was a problem hiding this comment.
Also it could mask some future issues with upgrades... 🤔
| @@ -34,9 +34,11 @@ | |||
| dest: /tmp/vault_helm_chart_values.yaml | |||
| when: vault_helm_chart_values_bool | |||
|
|
|||
| - name: Install and configure Hashicorp Vault if enabled | |||
| - name: Install and configure Hashicorp Vault if enabled and no cloud service is used | |||
There was a problem hiding this comment.
Suggested change
| - name: Install and configure Hashicorp Vault if enabled and no cloud service is used | |
| - name: Install and configure Hashicorp Vault if enabled and no cloud k8s service is used |
| @@ -103,3 +103,8 @@ | |||
| lineinfile: | |||
| path: "/home/{{ admin_user.name }}/.bashrc" | |||
| line: source <(kubectl completion bash) | |||
|
|
|||
| - name: Include Helm binary installation | |||
There was a problem hiding this comment.
Suggested change
| - name: Include Helm binary installation | |
| - name: Install Helm binary file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.