ODFE: Switch to Garbage-First Garbage Collector (G1GC) #1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
rafzei
changed the title
atsikham
suggested changes
Oct 5, 2020
| @@ -2,8 +2,7 @@ | |||
| - name: Install Open Distro for Elasticsearch packages | |||
| yum: | |||
| name: | |||
| - java-1.8.0-openjdk-headless | |||
There was a problem hiding this comment.
Is JDK installed somewhere else?
There was a problem hiding this comment.
We are using elasticsearch-oss, no elasitcsearch-oss-no-jdk. JDK is bundled and used by default. I did some briefly checks and it looks like we dont need to install additional java. (During tests it may turn out otherwise)
| 8:-XX:GCLogFileSize=64m | ||
|
|
||
| # JDK 9+ GC logging | ||
| 9-:-Xlog:gc*,gc+age=trace,safepoint:file=/var/log/elasticsearch/gc.log:utctime,pid,tags:filecount=32,filesize=64m |
There was a problem hiding this comment.
Could you add information to the doc or reference somewhere about JVM setting for different JDK versions?
There was a problem hiding this comment.
Yes, I can provide this information after upgrading ODFE to the latest version (#1719).
erzetpe
approved these changes
Oct 6, 2020
This was referenced Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.