-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node-exporter as DaemonSet for "K8S as cloud service" #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpudlowski93
changed the title
[FEATURE] Node-exporter as DaemonSet for "K8S as cloud service"
Node-exporter as DaemonSet for "K8S as cloud service"
Sep 29, 2020
sk4zuzu
suggested changes
Sep 29, 2020
sk4zuzu
suggested changes
Sep 30, 2020
...epicli/data/common/ansible/playbooks/roles/helm_charts/files/system/node-exporter/Chart.yaml
Outdated
Show resolved
Hide resolved
...picli/data/common/ansible/playbooks/roles/helm_charts/files/system/node-exporter/values.yaml
Outdated
Show resolved
Hide resolved
sk4zuzu
suggested changes
Sep 30, 2020
core/src/epicli/data/common/ansible/playbooks/roles/node_exporter/tasks/main.yml
Outdated
Show resolved
Hide resolved
core/src/epicli/data/common/ansible/playbooks/roles/node_exporter/tasks/main.yml
Outdated
Show resolved
Hide resolved
core/src/epicli/data/common/ansible/playbooks/roles/node_exporter/tasks/main.yml
Outdated
Show resolved
Hide resolved
core/src/epicli/data/common/ansible/playbooks/roles/node_exporter/tasks/main.yml
Outdated
Show resolved
Hide resolved
core/src/epicli/data/common/ansible/playbooks/roles/node_exporter/tasks/main.yml
Outdated
Show resolved
Hide resolved
core/src/epicli/data/common/ansible/playbooks/roles/node_exporter/tasks/main.yml
Outdated
Show resolved
Hide resolved
to-bar
previously requested changes
Sep 30, 2020
...epicli/data/common/ansible/playbooks/roles/helm_charts/files/system/node-exporter/Chart.yaml
Outdated
Show resolved
Hide resolved
sk4zuzu
suggested changes
Oct 1, 2020
...mmon/ansible/playbooks/roles/node_exporter/tasks/install-node-exporter-as-system-service.yml
Outdated
Show resolved
Hide resolved
...mmon/ansible/playbooks/roles/node_exporter/tasks/install-node-exporter-as-system-service.yml
Outdated
Show resolved
Hide resolved
...mmon/ansible/playbooks/roles/node_exporter/tasks/install-node-exporter-as-system-service.yml
Show resolved
Hide resolved
...picli/data/common/ansible/playbooks/roles/prometheus/tasks/configure-k8s-apps-monitoring.yml
Outdated
Show resolved
Hide resolved
...picli/data/common/ansible/playbooks/roles/prometheus/tasks/configure-k8s-apps-monitoring.yml
Outdated
Show resolved
Hide resolved
...picli/data/common/ansible/playbooks/roles/prometheus/tasks/configure-k8s-apps-monitoring.yml
Outdated
Show resolved
Hide resolved
sk4zuzu
previously approved these changes
Oct 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sk4zuzu
suggested changes
Oct 1, 2020
...ta/common/ansible/playbooks/roles/node_exporter/tasks/install-node-exporter-as-daemonset.yml
Outdated
Show resolved
Hide resolved
sk4zuzu
previously approved these changes
Oct 1, 2020
atsikham
suggested changes
Oct 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please add information to changelog.
erzetpe
previously approved these changes
Oct 2, 2020
erzetpe
previously approved these changes
Oct 2, 2020
atsikham
previously approved these changes
Oct 2, 2020
Kubeconfig environment added to playbook Kubeconfig environment added to playbook Changelog updated with Node Exporter as DaemonSet node-exporter as DaemonSet node-exporter as DaemonSet node-exporter as DaemonSet node-exporter as DaemonSet node-exporter as DaemonSet Removed 'Set Kubernetes credentials' task in Prometheus Role. Repository Rebased Update core/src/epicli/data/common/ansible/playbooks/roles/node_exporter/tasks/install-node-exporter-as-system-service.yml Co-authored-by: Michał Opala <sk4zuzu@gmail.com> Update core/src/epicli/data/common/ansible/playbooks/roles/node_exporter/tasks/install-node-exporter-as-system-service.yml Co-authored-by: Michał Opala <sk4zuzu@gmail.com> Update core/src/epicli/data/common/ansible/playbooks/roles/prometheus/tasks/configure-k8s-apps-monitoring.yml Co-authored-by: Michał Opala <sk4zuzu@gmail.com>
erzetpe
approved these changes
Oct 2, 2020
sk4zuzu
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR related to task #1673