-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
separate repository machine [#1640] #1687
separate repository machine [#1640] #1687
Conversation
0e8b8ac
to
9ddaba5
Compare
core/src/epicli/data/azure/defaults/infrastructure/virtual-machine.yml
Outdated
Show resolved
Hide resolved
core/src/epicli/data/aws/defaults/infrastructure/virtual-machine.yml
Outdated
Show resolved
Hide resolved
core/src/epicli/data/common/ansible/playbooks/roles/helm/tasks/main.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ar3ndt I believe minimal-cluster-config.yml for the "any" provider is missing 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also running it on this branch with some old config gives:
09:22:47 INFO cli.engine.ansible.AnsibleCommand - task path: /workspaces/epiphany/core/src/epicli/clusters/build/any1/ansible/roles/preflight_facts/tasks/kubernetes.yml:124
09:22:47 ERROR cli.engine.ansible.AnsibleCommand - fatal: [x1a1]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'dict object' has no attribute 'repository'\n\nThe error appears to be in '/workspaces/epiphany/core/src/epicli/clusters/build/any1/ansible/roles/preflight_facts/tasks/kubernetes.yml': line 124, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: PREFLIGHT_FACTS | Produce default repository and image registry urls\n ^ here\n"}
09:22:47 ERROR cli.engine.ansible.AnsibleCommand - fatal: [x1a2]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'dict object' has no attribute 'repository'\n\nThe error appears to be in '/workspaces/epiphany/core/src/epicli/clusters/build/any1/ansible/roles/preflight_facts/tasks/kubernetes.yml': line 124, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: PREFLIGHT_FACTS | Produce default repository and image registry urls\n ^ here\n"}
09:22:47 ERROR cli.engine.ansible.AnsibleCommand - fatal: [x1b1]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'dict object' has no attribute 'repository'\n\nThe error appears to be in '/workspaces/epiphany/core/src/epicli/clusters/build/any1/ansible/roles/preflight_facts/tasks/kubernetes.yml': line 124, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: PREFLIGHT_FACTS | Produce default repository and image registry urls\n ^ here\n"}
09:22:47 ERROR cli.engine.ansible.AnsibleCommand - fatal: [x1b2]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'dict object' has no attribute 'repository'\n\nThe error appears to be in '/workspaces/epiphany/core/src/epicli/clusters/build/any1/ansible/roles/preflight_facts/tasks/kubernetes.yml': line 124, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: PREFLIGHT_FACTS | Produce default repository and image registry urls\n ^ here\n"}
09:22:47 ERROR cli.engine.ansible.AnsibleCommand - fatal: [x1b3]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'dict object' has no attribute 'repository'\n\nThe error appears to be in '/workspaces/epiphany/core/src/epicli/clusters/build/any1/ansible/roles/preflight_facts/tasks/kubernetes.yml': line 124, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: PREFLIGHT_FACTS | Produce default repository and image registry urls\n ^ here\n"}
09:22:47 ERROR cli.engine.ansible.AnsibleCommand - fatal: [x1a3]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'dict object' has no attribute 'repository'\n\nThe error appears to be in '/workspaces/epiphany/core/src/epicli/clusters/build/any1/ansible/roles/preflight_facts/tasks/kubernetes.yml': line 124, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: PREFLIGHT_FACTS | Produce default repository and image registry urls\n ^ here\n"}
Are we aiming for enabling this by default and break existing clusters?
If so why there is no documentation about it or any kind of a warning? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look here:
https://github.com/epiphany-platform/epiphany/blob/cc944fd1a5ca9f8649bf4446a4470a32cf0e6ad5/core/src/epicli/data/common/ansible/playbooks/roles/helm/tasks/main.yml#L12-L15
Target host changed to localhost but this code didn't. That means that we are trying to do some stuff on ansible controller that we were previously doing on the remote. I don't think that is correct. 🤔
The full path here would be /var/www/html/epirepo/helm-charts/system
here on the localhost, that hardly makes any sense IMO 👎 :( Please prove me wrong if I'm mistaken 👍 :)
added |
working on it |
this code actually is not neccessary here. Deleted |
added changelog note |
c67687f
to
46c8dbe
Compare
@ar3ndt I executed one test in vscode using "any" provider from your branch. I got this error:
Cluster config I used: kind: epiphany-cluster
title: "Epiphany cluster Config"
provider: any
name: any1
specification:
name: any1
admin_user:
name: ubuntu
key_path: /workspaces/epiphany/core/src/epicli/clusters/id_rsa
components:
kubernetes_master:
count: 1
machines:
- default-k8s-master1
kubernetes_node:
count: 3
machines:
- default-k8s-node1
- default-k8s-node2
- default-k8s-node3
repository:
count: 1
machines:
- default-k8s-master2
postgresql:
count: 1
machines:
- default-k8s-master3
---
kind: configuration/shared-config
title: Shared configuration that will be visible to all roles
name: default
specification:
use_ha_control_plane: true
promote_to_ha: false
provider: any
---
kind: infrastructure/machine
provider: any
name: default-k8s-master1
specification:
hostname: x1a1
ip: 10.20.2.10
---
kind: infrastructure/machine
provider: any
name: default-k8s-master2
specification:
hostname: x1a2
ip: 10.20.2.11
---
kind: infrastructure/machine
provider: any
name: default-k8s-master3
specification:
hostname: x1a3
ip: 10.20.2.12
---
kind: infrastructure/machine
provider: any
name: default-k8s-node1
specification:
hostname: x1b1
ip: 10.20.2.20
---
kind: infrastructure/machine
provider: any
name: default-k8s-node2
specification:
hostname: x1b2
ip: 10.20.2.21
---
kind: infrastructure/machine
provider: any
name: default-k8s-node3
specification:
hostname: x1b3
ip: 10.20.2.22 What is wrong with my setup? 🤔 |
checking |
fixed |
462fd18
to
d95f1af
Compare
core/src/epicli/data/aws/defaults/infrastructure/virtual-machine.yml
Outdated
Show resolved
Hide resolved
core/src/epicli/data/azure/defaults/infrastructure/virtual-machine.yml
Outdated
Show resolved
Hide resolved
core/src/epicli/data/common/ansible/playbooks/roles/helm/tasks/install-chart.yml
Outdated
Show resolved
Hide resolved
core/src/epicli/data/common/ansible/playbooks/roles/helm/tasks/main.yml
Outdated
Show resolved
Hide resolved
core/src/epicli/data/common/ansible/playbooks/roles/helm/tasks/main.yml
Outdated
Show resolved
Hide resolved
core/src/epicli/data/common/ansible/playbooks/roles/helm/tasks/main.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one change needed from my side in this PR (comment left). Moreover, it is necessary to change in core/src/epicli/data/common/ansible/playbooks/roles/repository/tasks/create-helm-repo.yml
{{ repository_url }} to localhost. Except of these two changes, everything works fine, tested. Good job :)
core/src/epicli/data/common/ansible/playbooks/roles/helm/tasks/install-chart.yml
Outdated
Show resolved
Hide resolved
core/src/epicli/data/aws/defaults/infrastructure/virtual-machine.yml
Outdated
Show resolved
Hide resolved
core/src/epicli/data/aws/defaults/infrastructure/virtual-machine.yml
Outdated
Show resolved
Hide resolved
core/src/epicli/data/azure/defaults/infrastructure/virtual-machine.yml
Outdated
Show resolved
Hide resolved
core/src/epicli/data/common/ansible/playbooks/roles/helm/tasks/install-chart.yml
Outdated
Show resolved
Hide resolved
ef49c8b
to
d1d8f56
Compare
core/src/epicli/data/aws/defaults/infrastructure/virtual-machine.yml
Outdated
Show resolved
Hide resolved
core/src/epicli/data/azure/defaults/infrastructure/virtual-machine.yml
Outdated
Show resolved
Hide resolved
2ad74aa
to
95cc078
Compare
95cc078
to
2e36027
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.