Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

additional defaults for kafka config #1329 #1529

Merged
merged 1 commit into from
Aug 7, 2020
Merged

additional defaults for kafka config #1329 #1529

merged 1 commit into from
Aug 7, 2020

Conversation

ar3ndt
Copy link
Contributor

@ar3ndt ar3ndt commented Aug 5, 2020

No description provided.

@ar3ndt ar3ndt linked an issue Aug 5, 2020 that may be closed by this pull request
Provide possibility to change additional parameters in default kafka configuration #1329
Closed
rafzei
rafzei previously approved these changes Aug 6, 2020
View reviewed changes
@seriva
Copy link
Collaborator

seriva commented Aug 6, 2020

Hey, would it be possible to include these if they are not already?

  1. num.replica.fetchers: https://kafka.apache.org/documentation/#num.replica.fetchers
  2. replica.fetch.max.bytes: https://kafka.apache.org/documentation/#replica.fetch.max.bytes
  3. replica.socket.receive.buffer.bytes: https://kafka.apache.org/documentation/#replica.socket.receive.buffer.bytes

These might become important soon. They should be default like the other additions.

@ar3ndt
Copy link
Contributor Author

ar3ndt commented Aug 6, 2020

Hey, would it be possible to include these if they are not already?

  1. num.replica.fetchers: https://kafka.apache.org/documentation/#num.replica.fetchers
  2. replica.fetch.max.bytes: https://kafka.apache.org/documentation/#replica.fetch.max.bytes
  3. replica.socket.receive.buffer.bytes: https://kafka.apache.org/documentation/#replica.socket.receive.buffer.bytes

These might become important soon. They should be default like the other additions.

sure will add

seriva
seriva approved these changes Aug 7, 2020
View reviewed changes
Copy link
Collaborator

@seriva seriva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure this makes it in some changelog as well pls.

@ar3ndt ar3ndt merged commit 3810375 into hitachienergy:develop Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seriva seriva seriva approved these changes

@rafzei rafzei rafzei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide possibility to change additional parameters in default kafka configuration
3 participants
@ar3ndt @seriva @rafzei