Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preflight_facts: fixing inability to disable kubernetes #1346

Merged
merged 3 commits into from
Jun 15, 2020

Conversation

sk4zuzu
Copy link
Contributor

@sk4zuzu sk4zuzu commented Jun 8, 2020

Fixes regression issue #1183.

@sk4zuzu sk4zuzu requested a review from przemyslavic June 8, 2020 18:22
@sk4zuzu sk4zuzu changed the title preflight_facts: fixinig inability to disable kubernetes preflight_facts: fixing inability to disable kubernetes Jun 8, 2020
@sk4zuzu sk4zuzu force-pushed the hotfix/preflight-facts-fix branch from db0100d to c9e757a Compare June 8, 2020 18:24
@seriva
Copy link
Collaborator

seriva commented Jun 9, 2020

Missing change log entry.

@toszo
Copy link
Contributor

toszo commented Jun 9, 2020

Please link issues related to this PR

mkyc
mkyc previously approved these changes Jun 9, 2020
@sk4zuzu sk4zuzu merged commit 615cce6 into hitachienergy:develop Jun 15, 2020
sk4zuzu added a commit to sk4zuzu/epiphany that referenced this pull request Jun 17, 2020
…y#1346)

* preflight_facts: fixing critical regression problem with inability to disable kubernetes

* validation: adding kubernetes components dependency check for the epiphany-cluster doc

* updating changelogs for v0.6.1
sk4zuzu added a commit to sk4zuzu/epiphany that referenced this pull request Jun 17, 2020
…energy#1346)

* preflight_facts: fixing critical regression problem with inability to disable kubernetes

* validation: adding kubernetes components dependency check for the epiphany-cluster doc

* updating changelogs for v0.6.1
sk4zuzu added a commit that referenced this pull request Jun 17, 2020
…1365)

* preflight_facts: fixing critical regression problem with inability to disable kubernetes

* validation: adding kubernetes components dependency check for the epiphany-cluster doc

* updating changelogs for v0.6.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task 'Check if /etc/kubernetes/admin.conf file exists' fails when kubernetes_master.count = 0
6 participants