Fixes for several reported issues #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
seriva
commented
Mar 23, 2020
seriva
commented
- Added missing template for disk_size_gb storage_os_disk (For vm template on Azure disk_size_gb is missing in storage_os_disk #1043)
- Add ability to add subsciptionId to sp.yml on Azure (Add ability to add subsciptionId to sp.yml on Azure #1044)
- Added Epicli binary and python decencies/components.
- Updated documentation about sp.yml to show usage of " for values that have YAML schema characters.
…at have YAML schema characters.
erzetpe
suggested changes
Mar 23, 2020
erzetpe
previously approved these changes
Mar 23, 2020
plirglo
reviewed
Mar 23, 2020
plirglo
reviewed
Mar 23, 2020
| @@ -90,5 +93,26 @@ def _main() -> None: | |||
| with open(path, 'w') as file: | |||
| file.write(licenses_content) | |||
|
|
|||
| # Write components table to be pasted into 'COMPONENTS.md' | |||
| dependancies_content = """ | |||
plirglo
reviewed
Mar 23, 2020
| dep_line = f'| {dep_name} | {dep_version} | {dep_website} | [{dep_license}]({dep_license_url}) |\n' | ||
| else: | ||
| dep_line = f'| {dep_name} | {dep_version} | {dep_website} | {dep_license} |\n' | ||
| dependancies_content = dependancies_content + dep_line |
|
|
||
| path = os.path.join(os.path.dirname(__file__), 'DEPENDENCIES.md') | ||
| with open(path, 'w') as file: | ||
| file.write(dependancies_content) |
erzetpe
approved these changes
Mar 23, 2020
plirglo
approved these changes
Mar 23, 2020
to-bar
pushed a commit
to to-bar/epiphany
that referenced
this pull request
May 6, 2020
- Added missing template for disk_size_gb storage_os_disk (hitachienergy#1043) - Add ability to add subsciptionId to sp.yml on Azure (hitachienergy#1044) - Added Epicli binary and python decencies/components. - Updated documentation about sp.yml to show usage of " for values that have YAML schema characters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.