-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
return git info in /extended/v1/status #724
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/blockstack/stacks-blockchain-api/DDBpk9NxEcUq2Jm52Wsom9xR7cWq |
Codecov Report
@@ Coverage Diff @@
## develop #724 +/- ##
===========================================
- Coverage 65.75% 65.72% -0.04%
===========================================
Files 78 79 +1
Lines 8002 8020 +18
Branches 1254 1255 +1
===========================================
+ Hits 5262 5271 +9
- Misses 2735 2744 +9
Partials 5 5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
cc @CharlieC3 for any gotchas around the way we're bundling git info here, for example is the updated version tag going to be available at this stage of the build process during automated releases?
I think it will be available. The step which builds and publishes the docker image runs after the semantic release step which creates the new tag. Plus, the |
Thanks @CharlieC3 @zone117x 👍 |
🎉 This PR is included in version 0.65.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
This PR adds git info (latest tag, current branch, current commit hash) to the /extended/v1/status endpoint so users can determine which API version they're currently running.
Closes #577
Type of Change
Does this introduce a breaking change?
No
Are documentation updates required?
Yes, endpoint documentation should be updated.
Testing information
Running
npm run git-info
regenerates the git file. This can be tested by calling /extended/v1/status.Checklist
npm run test
passes