fix: use an independent sql connection for mempool stats #2217
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Vercel deployment URL: https://stacks-blockchain-6vfvfmmoj-hirosystems.vercel.app 🚀 |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
zone117x
approved these changes
Feb 5, 2025
blockstack-devops
pushed a commit
that referenced
this pull request
Feb 6, 2025
## [8.6.0-beta.2](v8.6.0-beta.1...v8.6.0-beta.2) (2025-02-06) ### Bug Fixes * use an independent sql connection for mempool stats ([#2217](#2217)) ([f8137e4](f8137e4))
|
🎉 This PR is included in version 8.6.0-beta.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
blockstack-devops
pushed a commit
that referenced
this pull request
Feb 6, 2025
## [8.6.0](v8.5.0...v8.6.0) (2025-02-06) ### Features * consider tenure block fullness for transaction fee estimations ([#2203](#2203)) ([396e2ea](396e2ea)) * store total transaction size in blocks table ([#2204](#2204)) ([ac7c41b](ac7c41b)) ### Bug Fixes * make tx_total_size column nullable ([#2207](#2207)) ([77bd2f8](77bd2f8)) * use an independent sql connection for mempool stats ([#2217](#2217)) ([f8137e4](f8137e4))
|
🎉 This PR is included in version 8.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
confirmed i was able to reach chain tip using this branch, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this debounced mempool stats calculator query was sharing a single sql connection with the pg writer. If the debounced trigger coincided with a new block ingestion, both tasks reused the same SQL transaction resulting in a race condition: as soon as the block ingestion ended, the mempool stats query was cut short because the transaction was committed. This resulted in a
CONNECTION_DESTROYEDpostgres error as described here: stacks-network/stacks-core#5663This PR moves the mempool stats query to its own SQL connection