Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update mempool garbage collection logic for 3.0 #2117

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

rafaelcr
Copy link
Collaborator

@rafaelcr rafaelcr commented Oct 11, 2024

Changes the logic for mempool transaction garbage collection depending on which Stacks epoch is active so it adapts to the corresponding implementation on stacks-core:

  • If epoch is 2.5 or lower, prune after 256 blocks
  • If epoch is 3.0 or higher, prune after 2560 minutes

Copy link

github-actions bot commented Oct 11, 2024

Vercel deployment URL: https://stacks-blockchain-k6396frsy-hirosystems.vercel.app 🚀

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@rafaelcr rafaelcr requested a review from zone117x October 11, 2024 22:54
@rafaelcr rafaelcr marked this pull request as ready for review October 11, 2024 22:54
@rafaelcr rafaelcr merged commit 8b10b69 into beta Oct 14, 2024
27 checks passed
@rafaelcr rafaelcr deleted the fix/garbage-collect branch October 14, 2024 14:54
blockstack-devops pushed a commit that referenced this pull request Oct 15, 2024
## [8.1.0-beta.3](v8.1.0-beta.2...v8.1.0-beta.3) (2024-10-15)

### Bug Fixes

* randomize key order for testnet stx faucet transactions ([#2120](#2120)) ([f7265f9](f7265f9))
* update mempool garbage collection logic for 3.0 ([#2117](#2117)) ([8b10b69](8b10b69))
@blockstack-devops
Copy link

🎉 This PR is included in version 8.1.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

blockstack-devops pushed a commit that referenced this pull request Oct 16, 2024
## [8.1.0](v8.0.4...v8.1.0) (2024-10-16)

### Features

* add block etag ([#2103](#2103)) ([66e6800](66e6800))
* add cache handler for principal activity including mempool transactions ([#2100](#2100)) ([2370c21](2370c21))
* add principal cache etag to account endpoints ([#2097](#2097)) ([28e9864](28e9864))
* return estimated balance in account balance endpoints ([#2104](#2104)) ([e217cea](e217cea))

### Bug Fixes

* add declaration copy step in build ([#2110](#2110)) ([2b6aa6a](2b6aa6a))
* prune and restore mempool transactions with equal nonces for the same sender ([#2091](#2091)) ([1ce75de](1ce75de))
* randomize key order for testnet stx faucet transactions ([#2120](#2120)) ([f7265f9](f7265f9))
* update mempool garbage collection logic for 3.0 ([#2117](#2117)) ([8b10b69](8b10b69))
* use total_count CTE and return it with the parsed results ([#2073](#2073)) ([bb30911](bb30911))
@blockstack-devops
Copy link

🎉 This PR is included in version 8.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants