feat: add cache control to /extended/v1/tx/:tx_id
#1229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1229 +/- ##
==========================================
+ Coverage 76.16% 76.25% +0.08%
==========================================
Files 96 96
Lines 9748 9772 +24
Branches 1983 1989 +6
==========================================
+ Hits 7425 7452 +27
+ Misses 2209 2207 -2
+ Partials 114 113 -1
Continue to review full report at Codecov.
|
zone117x
reviewed
Jul 7, 2022
blockstack-devops
pushed a commit
that referenced
this pull request
Jul 7, 2022
# [4.1.0](v4.0.4...v4.1.0) (2022-07-07) ### Features * add cache control to `/extended/v1/tx/:tx_id` ([#1229](#1229)) ([8d5ca2c](8d5ca2c))
|
🎉 This PR is included in version 4.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
ETagheader to/extended/v1/tx/:tx_idand/extended/v1/tx/:tx_id/raw.Since transactions can be in the mempool or in the chain and they can later get re-orged, a new
ETagType.transactionwas added which builds the ETag using thetx_id,index_block_hash(if any),microblock_hash(if any), andstatusof the relevant transaction. This way, we'll get the best caching behavior even when the tx may be moved from block to microblock to mempool and back.Closes #1225