Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove transferred names from address endpoint #714

Closed
markmhendrickson opened this issue Aug 18, 2021 · 3 comments · Fixed by #730
Closed

Remove transferred names from address endpoint #714

markmhendrickson opened this issue Aug 18, 2021 · 3 comments · Fixed by #730
Assignees
@asimm241
Labels
bug Something isn't working P2 Priority 2 Critical functionality not working Impacts one/few customers released

Comments

@markmhendrickson
Copy link

markmhendrickson commented Aug 18, 2021 •
edited by zone117x
Loading

Currently it appears that names are still returned by the address endpoint even once they've been transferred to another address.

See leather-io/extension#1551 (comment)

Hmm digging into this more, the api reports the original owner as the current owner: https://stacks-node-api.mainnet.stacks.co/v1/addresses/stacks/SPTCSBVXZ6KNV7JEMHAV7KJM9183VAP31053H0R4

However, there was a name transfer event: https://explorer.stacks.co/txid/0x79ad2a1a264d049f13842f0f055f0a40073488c74277fb4a899ec0355d13d8a6?chain=mainnet

The api shows this account: https://stacks-node-api.mainnet.stacks.co/extended/v1/address/SP3JKC09PH0RH8G1XVT031J3E3S0GJ15DEMG7EAZP/assets does infact own the name.

This is likely an API bug that should be fixed when we have a new deployment, but cc @zone117x to be sure.

Once microblocks is launched on the api side, we should come back and confirm this is correct.

Originally posted by @aulneau in leather-io/extension#1551 (comment)

Looking into this today, I seem to have the same issue in one of my accounts. This name transfer was successful, but it is still showing up in my wallet: https://explorer.stacks.co/txid/0x30a1a3d18709ddcd70ddb4fb904feeaf3cf5538aa724b7b5e78081fed6395ad0?chain=mainnet

Transferred from:
https://stacks-node-api.mainnet.stacks.co/v1/addresses/stacks/SP2J1ZFZ5BYTD7H7F84CCZ2B4HEJSBV060XW79G1X

Transferred to:
https://stacks-node-api.mainnet.stacks.co/v1/addresses/stacks/SP9CMJ7S8XR25H6ZKAJXT4M7KSPQ1B8PPVSYJRTC

Originally posted by @fbwoolf in leather-io/extension#1551 (comment)
@markmhendrickson markmhendrickson added the bug Something isn't working label Aug 18, 2021
@markmhendrickson markmhendrickson mentioned this issue Aug 18, 2021
Closed
@zone117x zone117x self-assigned this Aug 24, 2021
@zone117x zone117x added the P2 Priority 2 Critical functionality not working Impacts one/few customers label Aug 24, 2021
@zone117x zone117x assigned asimm241 and unassigned zone117x Aug 30, 2021
@asimm241 asimm241 mentioned this issue Aug 31, 2021
Merged
9 tasks
@asimm241 asimm241 linked a pull request Sep 1, 2021 that will close this issue
Return only latest name by address #730
Merged
9 tasks
zone117x pushed a commit that referenced this issue Sep 20, 2021
@asimm241
fix: return the latest name by address #714
101922b
blockstack-devops pushed a commit that referenced this issue Sep 20, 2021
@semantic-release-bot
chore(release): 0.68.0 [skip ci]
73ec732 
# [0.68.0](v0.67.1...v0.68.0) (2021-09-20)

### Bug Fixes

* return the latest name by address [#714](#714) ([101922b](101922b))

### Features

* ability to configure multiple tx broadcast endpoints [#765](#765) ([8a9222a](8a9222a))
@blockstack-devops
Copy link

🎉 This issue has been resolved in version 0.68.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@fbwoolf fbwoolf mentioned this issue Sep 20, 2021
Closed
@zone117x
Copy link
Member

@asimm241 I think there's a bug in the fix for this issue -- it looks like the last owned name logic is inverted.
In the above example:

Transferred from:
https://stacks-node-api.mainnet.stacks.co/v1/addresses/stacks/SP2J1ZFZ5BYTD7H7F84CCZ2B4HEJSBV060XW79G1X

Transferred to:
https://stacks-node-api.mainnet.stacks.co/v1/addresses/stacks/SP9CMJ7S8XR25H6ZKAJXT4M7KSPQ1B8PPVSYJRTC

Only the original address has the name.

Looks like the same thing happening with this name: leather-io/extension#1706
Transferred from:
https://stacks-node-api.mainnet.stacks.co/v1/addresses/stacks/SP32QQ557KP1Q8DPBGJCZ6NTYXVC41AFK5AR28GGT
to:
https://stacks-node-api.mainnet.stacks.co/v1/addresses/stacks/SP3J8H2P4AFH1NK96BJJY9S2V5GW4SCV7MKW7A7P0

@zone117x zone117x reopened this Sep 23, 2021
This was referenced Sep 23, 2021
Merged
Closed
@asimm241
Copy link
Contributor

asimm241 commented Sep 23, 2021 •
edited
Loading

The problem was occurring because of the name owner being set incorrectly. I have created another issue to track that.
#779

This issue should be closed as it's not a problem with the query.

wileyj added a commit that referenced this issue Nov 16, 2021
@wileyj
Merge branch 'develop' into feat/cleanup
735c5de 
* develop: (40 commits)
  feat: added execution cost to block response #735
  feat: ability to configure multiple tx broadcast endpoints #765
  fix: return the latest name by address #714
  fix(rosetta): use coinbase txs hash instead of stx_lock for forged unlock_transaction #760
  feat: automatically generate postman collection from the openapi spec
  fix: disable http keep-alive for stacks-node /v2 proxied endpoints
  fix: increase the 10 second cap on prometheus http metric reporting
  chore: update typescript to 4.4.2
  feat(rosetta): support memos in stx token transfer operations #752
  fix: replicate query optimizations to other asset txs queries
  fix: optimize query that retrieves txs with asset transfers
  fix(rosetta): do not assume encoding of delegate-stx `pox_addr` data #732
  feat: added a new endpoint fee_rate #729
  chore(release): 0.65.0 [skip ci]
  fix: sql optimizations to speed up various tx queries
  feat: add execution cost data to transactions
  feat: token metadata
  fix: short summaries for BNS endpoints
  feat: emit prometheus metrics for socket.io
  fix: added types for search endpoint #645
  ...
@CharlieC3 CharlieC3 mentioned this issue Oct 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asimm241 asimm241

Labels
bug Something isn't working P2 Priority 2 Critical functionality not working Impacts one/few customers released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Return only latest name by address hirosystems/stacks-blockchain-api
4 participants
@markmhendrickson @zone117x @asimm241 @blockstack-devops