fix(socket-errors): fixed #1598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1598 +/- ##
==========================================
- Coverage 20.84% 20.82% -0.02%
==========================================
Files 447 447
Lines 7590 7591 +1
Branches 1590 1590
==========================================
- Hits 1582 1581 -1
Misses 5802 5802
- Partials 206 208 +2 ☔ View full report in Codecov by Sentry. |
He1DAr
approved these changes
Apr 26, 2024
blockstack-devops
pushed a commit
that referenced
this pull request
Apr 26, 2024
## [1.169.1](v1.169.0...v1.169.1) (2024-04-26) ### Bug Fixes * **socket-errors:** fixed ([#1598](#1598)) ([73c1505](73c1505))
|
🎉 This PR is included in version 1.169.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a looping socket error on localhost on mainnet.
The socket hook is trying to use the client set in state to close the socket but the state client is not defined when an immediate connection error takes place, which leads to the disconnect code to never run.
Now I am using the client var reference in the function to disconnect in addition to calling the disconnect code on the client in state if it exists