-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/blocklist #1569
Feat/blocklist #1569
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bd78613
to
5300061
Compare
src/app/_components/BlockList/AnimatedBlockAndMicroblocksItem.tsx
Outdated
Show resolved
Hide resolved
btcBlockBaseUrls={NetworkModeBtcBlockBaseUrlMap} | ||
btcTxBaseUrls={NetworkModeBtcTxBaseUrlMap} | ||
btcAddressBaseUrls={NetworkModeBtcAddressBaseUrlMap} | ||
apiUrls={NetworkModeUrlMap} // TODO: why does this need to be in context? remove. make a function that returns these. network should be in redux not context |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please fix this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not want to fix this in this PR. The PR is already too much. But I think we can leave the comment to fix later.
src/app/_components/BlockList/BlocksPage/BlocksPageBlockList.tsx
Outdated
Show resolved
Hide resolved
src/app/_components/BlockList/BlocksPage/BlocksPageBlockList.tsx
Outdated
Show resolved
Hide resolved
src/app/_components/BlockList/BlocksPage/BlocksPageBlockList.tsx
Outdated
Show resolved
Hide resolved
Fixed * There is a regression, the dropmenu is broken on small viewports Fixed. The backgroundground color had not been updated to the new semantic tokens * Why is there so much space to the right of the list item? Fixed Please make sure to swash the commits and rebase 🙏 I am going to do a squash merge commit |
da76fb7
to
7d492fc
Compare
🎉 This PR is included in version 1.169.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Implements the new designs for the grouped and ungrouped block list widgets on the home page and blocks page.
Figma - https://www.figma.com/file/31q1g27k69z1yXb6r6vrRD/Stacks-Explorer-Working-File?node-id=7090%3A101311&mode=dev
Also adds the new btc blocks page
Figma - https://www.figma.com/file/31q1g27k69z1yXb6r6vrRD/Stacks-Explorer-Working-File?node-id=7199%3A100786&mode=dev
The new background for the btc blocks page will go in a separate PR
Keeps the new UI hidden behind the api=https://api.nakamoto-1.hiro.so query param
Keeps the UI we have today, but we can also switch those out for the previous naka-1 blocklist widgets easily.
@eugeniadigon there were a lot of new colors used. I added a TODO in this PR to add them to the theme. Can you please take a look and see what's the best way to integrate them with the current theme we have.
Data missing:
Task Need to be able to get the average block time from the API stacks-blockchain-api#1919
Task Need to be able to get the average block time from the API stacks-blockchain-api#1919
This data needs to be included in the burn block data. Otherwise, I need to query for each stx block in a burn block. And that would mean removing the load more button at the bottom of the page and potentially making a lot of queries.
Data Issues:
It seems like the block time is just set to the burn block time. All the timestamps are the same
Here is the API PR that adds block time feat: add nakamoto block time to v2 endpoints stacks-blockchain-api#1921