Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/blocklist #1569

Merged
merged 70 commits into from
Apr 25, 2024
Merged

Feat/blocklist #1569

merged 70 commits into from
Apr 25, 2024

Conversation

BLuEScioN
Copy link
Collaborator

@BLuEScioN BLuEScioN commented Apr 17, 2024

Implements the new designs for the grouped and ungrouped block list widgets on the home page and blocks page.
Figma - https://www.figma.com/file/31q1g27k69z1yXb6r6vrRD/Stacks-Explorer-Working-File?node-id=7090%3A101311&mode=dev

Also adds the new btc blocks page
Figma - https://www.figma.com/file/31q1g27k69z1yXb6r6vrRD/Stacks-Explorer-Working-File?node-id=7199%3A100786&mode=dev
The new background for the btc blocks page will go in a separate PR

Keeps the new UI hidden behind the api=https://api.nakamoto-1.hiro.so query param
Keeps the UI we have today, but we can also switch those out for the previous naka-1 blocklist widgets easily.

@eugeniadigon there were a lot of new colors used. I added a TODO in this PR to add them to the theme. Can you please take a look and see what's the best way to integrate them with the current theme we have.

Data missing:

Data Issues:

@BLuEScioN BLuEScioN requested a review from He1DAr April 17, 2024 19:18
Copy link

vercel bot commented Apr 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hiro-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2024 8:37pm

src/app/_components/BlockList/Grouped/BlockListGrouped.tsx Outdated Show resolved Hide resolved
btcBlockBaseUrls={NetworkModeBtcBlockBaseUrlMap}
btcTxBaseUrls={NetworkModeBtcTxBaseUrlMap}
btcAddressBaseUrls={NetworkModeBtcAddressBaseUrlMap}
apiUrls={NetworkModeUrlMap} // TODO: why does this need to be in context? remove. make a function that returns these. network should be in redux not context
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please fix this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not want to fix this in this PR. The PR is already too much. But I think we can leave the comment to fix later.

src/app/PageClient.tsx Outdated Show resolved Hide resolved
@andresgalante
Copy link
Member

Hi Nick, thanks for this PR! I was looking forward to reviewing it. I have a couple of questions:

  • Can we preview the block list with data (epoch 3)?

  • Why are we changing the testnet 2.5 views with this one? We decided to keep the current one and only replace it with this one once we reach 3.0. This view should be a hidden link to test.

A couple of things I noticed on the UI:

  • The responsive table shows a few pixels to the left of the vertical line
image
  • The block hash goes outside the box
image
  • There is a regression, the dropmenu is broken on small viewports
image
  • Why is there so much space to the right of the list item?
image

Please make sure to swash the commits and rebase 🙏

@BLuEScioN
Copy link
Collaborator Author

BLuEScioN commented Apr 23, 2024

Hi Nick, thanks for this PR! I was looking forward to reviewing it. I have a couple of questions:

  • Can we preview the block list with data (epoch 3)?
    Yes just add ?chain=testnet&api=https://api.nakamoto-1.hiro.so to the query parameter section of the url
  • Why are we changing the testnet 2.5 views with this one? We decided to keep the current one and only replace it with this one once we reach 3.0. This view should be a hidden link to test.

A couple of things I noticed on the UI:

  • The responsive table shows a few pixels to the left of the vertical line
    I don't see this so I think it is fixed
image * The block hash goes outside the box

Fixed

image * There is a regression, the dropmenu is broken on small viewports

Fixed. The backgroundground color had not been updated to the new semantic tokens

image * Why is there so much space to the right of the list item?

Fixed

image Please make sure to swash the commits and rebase 🙏

I am going to do a squash merge commit

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 20.13752% with 813 lines in your changes are missing coverage. Please review.

Project coverage is 20.84%. Comparing base (bf15dc0) to head (830ccbc).
Report is 6 commits behind head on main.

Files Patch % Lines
src/app/_components/BlockList/utils.ts 19.64% 42 Missing and 3 partials ⚠️
...s/BlockList/data/useBlocksPageBlockListGrouped.tsx 0.00% 42 Missing and 2 partials ⚠️
.../BlockList/data/useBlocksPageBlockListUngrouped.ts 0.00% 42 Missing and 2 partials ⚠️
..._components/BlockList/data/useHomePageBlockList.ts 0.00% 42 Missing and 2 partials ⚠️
...ponents/BlockList/Ungrouped/BlockListUngrouped.tsx 32.81% 43 Missing ⚠️
..._components/BlockList/Grouped/BlockListGrouped.tsx 35.38% 42 Missing ⚠️
src/app/_components/BlockList/Grouped/skeleton.tsx 35.55% 29 Missing ⚠️
...ist/data/useBlocksPageUngroupedInitialBlockList.ts 0.00% 29 Missing ⚠️
...omponents/BlockList/HomePage/HomePageBlockList.tsx 0.00% 27 Missing and 1 partial ⚠️
...ents/BlockList/data/useHomePageInitialBlockList.ts 0.00% 27 Missing and 1 partial ⚠️
... and 42 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1569      +/-   ##
==========================================
- Coverage   21.11%   20.84%   -0.27%     
==========================================
  Files         417      447      +30     
  Lines        6764     7590     +826     
  Branches     1439     1590     +151     
==========================================
+ Hits         1428     1582     +154     
- Misses       5146     5802     +656     
- Partials      190      206      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@He1DAr
Copy link
Collaborator

He1DAr commented Apr 25, 2024

would you mind fixing this key error?
image

@He1DAr
Copy link
Collaborator

He1DAr commented Apr 25, 2024

could you remove the console logs?
image

@BLuEScioN
Copy link
Collaborator Author

would you mind fixing this key error? image

done

@BLuEScioN
Copy link
Collaborator Author

could you remove the console logs? image

done

@BLuEScioN BLuEScioN merged commit 8f1591a into main Apr 25, 2024
14 of 17 checks passed
@BLuEScioN BLuEScioN deleted the feat/blocklist branch April 25, 2024 20:40
@blockstack-devops
Copy link

🎉 This PR is included in version 1.169.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

5 participants