chore(release): publish v1.1.0 #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description <!-- Describe the bug this PR fixes or the feature it adds. Link to any related issues and PRs --> #### Breaking change? <!-- If applicable, list the APIs/functionality which this PR breaks --> ### Example <!-- If applicable, add an example on how this improves the application --> --- ### Checklist - [x] All tests pass - [x] Tests added in this PR (if applicable)
### Description
Previously, a serialized `PredicateStatus` would have the format:
```JSON
{ "scanning": { "last_evaluated_block": ... }
```
where the predicate status type is the key that points to the data. This
PR changes this format to be:
```JSON
{
"type": "scanning",
"info": { "last_evaluated_block": ... }
}
```
### Checklist
- [x] All tests pass
fix: op_return predicate evaluation
FAQ's -> FAQs
Fixes some bugs found along the way --- ### Checklist - [x] All tests pass - [x] Tests added in this PR (if applicable) Test coverage before: 47.07% Test coverage after: 63.30%
### Description Previously, when the unconfirmed predicate status was set after the status originally was scanning, we were adding the number of evaluated blocks with the previous statuses number of blocks. When scanning, we have a running total of blocks scanned, so we don't need to use the previously stored data. --- ### Checklist - [x] All tests pass - [x] Tests added in this PR (if applicable)
### Description This changes the predicate status timestamps: - from String (converted from a u128) to a u64 - this means we are now storing the data in seconds rather than milliseconds - makes them optional (so they will not appear in a serialized status if set to `None`) #### Breaking change? Previously the timestamp was in milliseconds, now it's in seconds. Anyone depending on the timestamp being in milliseconds could be impacted by this change. --- ### Checklist - [ ] All tests pass - [ ] Tests added in this PR (if applicable)
couple grammar tweaks
Tweaked grammar and voice
Update faq.md
changes to the CI workflow. adding auto deployments using docker container digest to the k8s repo. dev and stg will auto approve, while prod will require manual approval --------- Co-authored-by: Charlie <2747302+CharlieC3@users.noreply.github.com>
### Description The new field `include_contract_abi` already was optional for the user-facing type `StacksChainhookNetworkSpecification`, but was not optional for the internal type `StacksChainhookSpecification`. Any time we converted to a `StacksChainhookSpecification`, we'd `.unwrap_or(false)`, which seemed okay. However, a running Chainhook node has the `StacksChainhookSpecification` type saved in redis, so whenever a pre-existing node is restarted after upgrading, it is missing the required `include_contract_abi` field and errors. This PR makes the field optional everywhere. I'll need to think about how to add tests to prevent this sort of bug in the future. ### Checklist - [x] All tests pass - [ ] Tests added in this PR (if applicable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.