Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use authorization: token header for Github authentication #211

Merged
merged 2 commits into from
Feb 16, 2020
Merged

Use authorization: token header for Github authentication #211

merged 2 commits into from
Feb 16, 2020

Conversation

andytson-inviqa
Copy link
Contributor

Fixes GitHub deprecated query param authentication #210

Fixes GitHub deprecated query param authentication #210
@coveralls
Copy link

coveralls commented Feb 11, 2020

Coverage Status

Coverage decreased (-1.2%) to 81.773% when pulling fbc5e00 on andytson-inviqa:feature/github-authorization-header into 01bed92 on hirak:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.2%) to 81.773% when pulling 315454c on andytson-inviqa:feature/github-authorization-header into 01bed92 on hirak:master.

@vkarampinis
Copy link

@hirak any plans to merge this PR. We are getting a lot of mails from GitHub complaining about the access_token on parameters.

On February 12th, 2020 at 08:03 (UTC) your personal access token (jenkins) using Composer/1.9.3 (Linux; 4.14.146-93.123.amzn1.x86_64; PHP 7.2.22) was used as part of a query parameter to access an endpoint through the GitHub API:

https://api.github.com/repositories/xxxx/zipball/xxxx

Please use the Authorization HTTP header instead, as using the access_token query parameter is deprecated and will be removed July 1st, 2020.

Composer already made a fix for that on version 1.9.3

@hirak
Copy link
Owner

hirak commented Feb 16, 2020

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants