-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub deprecated query param authentication #210
Comments
added a PR #212 but @andytson-inviqa has tests with his fix. |
release 0.3.10 contains the fix for this now |
Sorry for the late reply. |
If I already have this installed, how does one update to 0.3.10? README doesn't mention updating - only installing. I know I can remove and reinstall, but updating would be easier. Edit: Looks like running |
Github has deprecated query parameter authentication (?access_token=....)
https://developer.github.com/changes/2019-11-05-deprecated-passwords-and-authorizations-api/#authenticating-using-query-parameters
This appears to be still be used in this composer plugin, which is causing Github to notify via email all Github accounts being used by this plugin.
This will need a change to use Authorization: token (or basic) authentication to continue beyond obsoletion, and to stop the Github email notifications being sent.
The lines of code which are doing this appear to be at:
prestissimo/src/BaseRequest.php
Lines 143 to 148 in 4c52352
There was some confusion in composer/composer#8586 as to the cause, when composer itself had fixed it in 1.9.3.
The text was updated successfully, but these errors were encountered: