Various fixes #16
Merged
Various fixes #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xepozz
pushed a commit
to xepozz/hiqdev-fork-composer-config-plugin
that referenced
this pull request
Apr 13, 2020
* Reader is context-aware, enhanced tests The main change of this PR is in ReaderFactory:35-40 and addresses the regression. During the refactoring, ReaderFactory behavior was optimized to create at most one reader for each type. However, the reader was designed to be context-aware, otherwise alternatives building does not work properly. This PR also contains Integration suite enhancements: - Symlink current project dir with composer-config-plugin instead of installing it from Packagist - Fixed path detection to rely on Composer instead of blindly-guessing it from dirs hierarchy (fixes for previous point) - Reduce Integration Test Suite scope to prevent scanning of Integration/Environment/vendor dir * Get rid of directories guessing * Call static method correctly * Fixed relative path to the project root * Removed useless setter * Code style fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.