Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

397 #469

Merged
merged 8 commits into from
Mar 16, 2017
Merged

397 #469

merged 8 commits into from
Mar 16, 2017

Conversation

aksonov
Copy link
Contributor

@aksonov aksonov commented Mar 16, 2017

#397 implementation

@bengtan
Copy link
Contributor

bengtan commented Mar 16, 2017

.1.
Just an idea ... In Bot.js:constructor(), type is probably redundant and can be removed. It doesn't have to be done for this PR so maybe leave it for some other time in the future.

.2.
BotService.js:

      if (current.var === 'followers+size') {
        total.followersSize = parseInt(current.value);
      } else if (current.var === 'subscribers+size'){
        total.followersSize = parseInt(current.value);

Don't need if (current.var === 'followers+size') ... anymore.

So, please fix up .2. and then go ahead and merge this yourself.

@aksonov aksonov merged commit abc7d1e into master Mar 16, 2017
@bengtan bengtan deleted the 397 branch April 4, 2017 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants