Loading screen visible when user taps "Sharing Location"

[mstidham]

Loading screen visible when user taps "Sharing Location"

QA TEMPLATE	Input
Device Type:	iPhone 7 Plus & Galaxy S10+
tr Version:	4.20.1
Environment	Prod & Staging
Codepush:
Internet Connection Type:	WiFi
Users affected?	Miranda
User handle:	@miranda
Bypass handle?:
Location access type?	Always
Does this issue occur on other environments?	Staging & Prod
Time issue occurred (UTC)

Observed Result:

If user taps on "Sharing Location" they briefly see the loading screen.

Expected Result:

User should only see this screen when opening the app

Steps to reproduce:

1. Tap on "Sharing Location" from owners profile

Related Screenshots/Video Links:

---

Video:
https://app.box.com/s/qg8m7lv3xoja53z5dhxsn8n3oharo3ag

[mstidham]

I'm still seeing this issue after the server fix. I also think the hit slop needs increased on the "Share Live Location" button.

[southerneer]

Since this is routing related I think it makes sense for @aksonov to take this one.

[bengtan]

Did some testing.

Happens on iOS Staging 4.20.1.

Happens on android Staging 4.20.1.

Happens on iOS Staging 4.20.0

Does not happen on iOS Staging 4.19.2.

[bengtan]

If I run: 4.20.0 + revert #3986, the problem doesn't happen. Looks like #3986 introduced it.

[mstidham]

Verified on Staging Version: 4.21.0

[mstidham]

Verified on Prod Version: 4.21.0