Hiding post from home screen

[mstidham]

Pavel when you select "hide this post" it is deleting the message but reloads the previous comment that was sent. It should remove the notification completely from the home screen. It should simply disappear.

[aksonov]

Steve told me implement such behavior

Pavel.

9 авг. 2016 г., в 23:18, mstidham notifications@github.com написал(а):

Pavel when you select "hide this post" it is deleting the message but reloads the previous comment that was sent. It should remove the notification completely from the home screen. It should simply disappear.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

[thescurry]

Hello @aksonov & @mstidham (cc: @benghippware)

I think there is a little bit of confusion, I will attempt to clarify. The "Hide this post" works in that it deletes the specific notification. The problem is, when it deletes a specific post, it replaces that post with a previous post. So the expect action is, when I tap "hide this post" that post should disappear and not be replaced by a previous notification from the same user.

Here is an example:

• Post 1.0 #1
• Post 1.0 #2
• Post release only branches starting with release prefix #3

The intended action is, if I tap "hide this post" for Post #2 I should see the following:

• Post 1.0 #1
• Post release only branches starting with release prefix #3

Post #2 has been hidden and is no longer viewable to me (the same as deleting the post/notification).

What happens today however is this. After I tap "Hide this post" for Post #2 I currently see the following:

• Post 1.0 #1
• Post 1.0 #2 (with old data from a previous notification)
• Post release only branches starting with release prefix #3

I should no longer see Post #2 as I chose to hide it... yet it's still there, but now with old data from a previous notification. This is a bit hard to explain... :) Maybe we should jump on a call tonight Pavel?

[aksonov]

@thescurry (cc @benghippware ). Okey, looks like we have misunderstanding here.
I guess the problem that we have quite strange requirement to "suppress" all user's chat posts into one post. So "hiding post" operation became not clear - should we remove one message or remove all chat messages. I've tried to clarify this term in the past and asked

"pavel [7:26 PM] @scurry so previous post should be shown for the user, right?" - scurry [7:28 PM]
@pavel: Yes after hiding a specific notification/post with "hide post", previous and future notifications/post would be still shown.

Post #1 of User A
Post #2 of User B (Messages B1, B2, B3 and B3 is shown)
Post #3 of User C
Now user wants to hide Post 2
Probably i didn't ask clearly - i've asked should app show previous B1, B2 messages in case of hiding post #2 with message B3. Now I see you want to remove all B1, B2, B3, but show all future B4,B5,etc.

Concept of Post here is quite unclear (because actually ONE Message is shown) so hiding of post is not clear as well.

It is not first time of such misunderstanding and probably we should change our workflow. As I know usually all such things are clarified by Product Manager and Product Manager creates 'Application Requirement Specification' where all cases are described. After that developer uses this document to create app. We don't have this at all and it is quite difficult - all i have is screenshots. Additional 'flow' charts from Kristina are very helpful but they don't cover many functionality (like "hide post(s)")

Whole conversation from Slack:
pavel [10:53 AM] @scurry: I’ve implement app behaviour according to this post. But looks like you want to have ability to hide only one Post now, right? Then probably we should have two options - Hide Post and Hide notifications for this user (current Hide users posts)?
kristina
IT should probably say something like “Show Max’s Posts” or “Hide Max’s Posts” to keep consistent with the way we’re handling the show/hide on the home feed
Posted in #designJuly 8th at 8:43 PM

----- August 1st -----
scurry [11:44 AM]
@pavel: yes, probably we need both. Lets rename the current feature to "hide notifications" and we need to also be able to remove individual notifications with "hide post". @erik @kristina does this make sense? I believe we enable notifications via the users profile settings/options?

pavel [12:09 PM] @scurry: ok
pavel [7:26 PM] @scurry so previous post should be shown for the user, right?
pavel [7:26] After hide post

scurry [7:28 PM] @pavel: Yes after hiding a specific notification/post with "hide post", previous and future notifications/post would be still shown.

[benghippware]

I haven't been following this thread so I'm out of the loop.

I think we have issues with terminology and ambiguity.

I'm going to suggest we use the term "tile" (for lack of a better word) to mean a collection of posts (on the Home Stream/Screen) from the same user.

Then, we can describe situations with less chance for misunderstanding.

For example:

Tile of Alice (Post A1)
Tile of Bob (Post B1, B2, B3)
Tile of Chris (Post C1)

I believe:

• There are separate "Hide this post" options for B1, B2, and B3?
• There is one "Hide Bob's posts" for Tile B?

@thescurry:

Is it correct to say that you think the intended behaviour is ... if you tap "Hide this post" for B1 (or B2 or B3), you expect the Tile B to disappear entirely (until there is a new post B4)?

[benghippware]

@aksonov: What's the current intended behaviour (as you understand it) and what's the current actual behaviour (in your testing)?

[aksonov]

@benghippware Steve said to preserve all previous and future posts before, so app behaviour now is removing B3 (as shown message) and show B2 instead (as previous post). Now I believe i should implement something i've described above (the same as your description within previous post)

[aksonov]

But i believe it will be not clear for user to see two different options "Hide this post" and "Hide Steve's posts" because they are the same with new interpretation (except probably Hide Steve's posts will disable future notifications too)

[benghippware]

Okay, let's just see what Steve says/clarifies before we jump into changing things.

[thescurry]

Hey guys, I'll do my best to clarify here and if needed we can jump on a slack call.

First of all let's clarify the HS (home screen) is essentially a waterfall of notifications. We call them posts in the app right now and maybe this is leading to some confusion? Regardless of what we call them, please consider them as notifications about things that are important for our users. These notifications are very generic as well, meaning it's not just incoming messages that appear on the HS. HS notifications could be notifications of an incoming message from a friend, but it could also be an update from a bot or even an alert from another users action (such as someone crossing into a bot perimeter). The intention for the HS is for notifications to waterfall down, I may receive an notification about a message from beng, receive three generic notifications and then receive another notification about a bot that beng created. These two separate notifications both would show up depending on the timeline they [the notifications] were created.

Example: (Posts A - D)

D. Message from Beng
C. Notification from Bot5
B. Notification from Bot9
A. Beng created a new bot!

It would be totally valid and expected that both of those notifications appear on my HS notification stream.

So now allow me to try and clarify one of Pavels comments above.

"pavel [7:26 PM] @scurry so previous post should be shown for the user, right?" - scurry [7:28 PM]

@pavel: Yes after hiding a specific notification/post with "hide post", previous and future >notifications/post would be still shown.

What I've said is correct. If I hide post D, Beng's previous post [Post A] will still show up in my HS notification stream. If Beng sends me a new message (let's say Post E) or by some other means generates future notifications to me, they will appear in the HS notification stream. Think of "hide this post" as delete or more specifically "deleting a specific notification".

Updated example: (Posts A - E)

E. Message from Beng
C. Notification from Bot5
B. Notification from Bot9
A. Beng created a new bot!

In the above example, we've deleted Post D (An earlier message notification from Beng) and since Beng sent a new message, a new notification was generated and appears on the HS stream. If Beng sends a new message again, "Post E" is updated with the latest message from Beng and placed at the top of the HS stream (it is moved to the top, because it's a new notification). Message notifications act a little different from other notifications. Allow me to further clarify, yes... we have said in the past and it is currently the desired action, that if a notification is generated from a specific user sending a message (let's call this a message notification) then you should only receive one of those per user (otherwise you could easily have a HS stream full of notifications from one user who may be chatty). So when I delete a message notification from any user, that notification is deleted. If the same user sends me a new message, a new notification is created. If the same user sends me another new message and I haven't deleted their previous message notification, then that previous notification is updated and moved back to the top of the HS stream. Again, this is to prevent message notification spam.

[benghippware]

Message notifications act a little different from other notifications.

So message notifications (and only message notifications) are "grouped" together into a tile?

I think the question then becomes ... if you "hide this post" on a message in a tile of multiple message notifications, does it hide/remove the entire tile, or just that individual message only (so the tile remains and the tiles shows other/previous message notifications of the tile)?

[benghippware]

On a related matter, I propose calling a group/"tile" of notifications a "stack". Until, or if, we come up with a better name.

[thescurry]

No, a notification is one thing, they are not grouped. So in other words, if you send me a message it generates notification A that says "hello steve". If you send me another message "are you there?", at that point notification A is updated to say "are you there" and it's position in the timeline of notifications is updated too. The previous message notification [from beng] content can just be thrown away.

[benghippware]

Talked to Steve. This is my paraphrasing of what he said.

"Normal" HS notifications are well understood.

(There is no stacking or tiles -- Forget what I said about tiles).

Except for message notifications. Message notifications are different.

• A HS message notification results in the previous (if there was one) message notification (from the same user) disappearing from the HS.
• This means there is a maximum of one message notification per user in the HS. When a new message notification arrives, the previous one disappears.

For example, HS has:

• Message from user Alice
• Bob has created a bot!
• Message from user Bob ("Hello world")
• Message from user Chris

Then, if Bob sends a new message ("How are you?"), the HS becomes:

• Message from user Bob ("How are you?")
• Message from user Alice
• Bob has created a bot!
• Message from user Chris

The new notification ("How are you?") appears at the top, and the previous notification ("Hello world") disappears.

(An alternate way of thinking of this is: The new notification replaces the previous message notification, but with an updated timestamp.)

If the user then does "hide this post" on Bob's "How are you?" notification, the HS becomes:

• Message from user Alice
• Bob has created a bot!
• Message from user Chris

The message notification ("How are you?") is hidden/deleted/removed. The previous message ("Hello World") does not re-appear because it disappeared a long time ago.

Then, if Bob sends a new message "Are you there?", the HS becomes:

• Message from user Bob ("Are you there?")
• Message from user Alice
• Bob has created a bot!
• Message from user Chris

[benghippware]

To summarise:

• A message notification causes the previous message notification (from the same user) (if there was one) to disppear.
• "Hide this post" removes only that one notification.
  • There shouldn't be any other message notifications (from the same user) in the HS. There should only be one, at maximum.
  • It doesn't stop future message notifications (from the same user) appearing in the HS.

In hindsight, this is a pretty subtle point and easy to miscommunicate.

[mstidham]

Works great!