Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev] don't ignore GraphQL errors on watchQuery #3353

Closed
southerneer opened this issue Feb 18, 2019 · 3 comments
Closed

[dev] don't ignore GraphQL errors on watchQuery #3353

southerneer opened this issue Feb 18, 2019 · 3 comments
Assignees

Comments

@southerneer
Copy link
Contributor

In the course of debugging issues with #3045 I stumbled onto a GraphQL problem. There were errors being generated on the server side that weren't making their way down to the client. Eventually I tried fiddling with the ApolloClient config in Transport.ts and discovered that we included errorPolicy: 'ignore'. I recall there was a good reason to do that at the time (maybe an extant bug in absinthe-socket?) but probably with the recent absinthe-socket update that setting needed to be reverted. Indeed when I commented out that config I was able to see the expected error message. We should also comment out the setting for watchQuery just in a separate PR with further testing to make sure it doesn't break anything.

@southerneer southerneer self-assigned this Feb 18, 2019
@aksonov
Copy link
Contributor

aksonov commented Feb 27, 2019

I guess it could be closed now

@aksonov aksonov closed this as completed Feb 27, 2019
@southerneer
Copy link
Contributor Author

We still ignore those errors (the line in Transport.ts changed though) so I'd still like to evaluate what happens when we don't ignore it.

@southerneer southerneer reopened this Feb 27, 2019
southerneer added a commit that referenced this issue Feb 27, 2019
aksonov added a commit that referenced this issue Feb 28, 2019
@bengtan
Copy link
Contributor

bengtan commented Mar 1, 2019

Not QA-able.

@bengtan bengtan closed this as completed Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants