Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invisible Mode: Presence widget is visible when user is in invisible mode #3016

Closed
mstidham opened this issue Oct 26, 2018 · 7 comments
Closed

Invisible Mode: Presence widget is visible when user is in invisible mode #3016

mstidham opened this issue Oct 26, 2018 · 7 comments
Assignees
@aksonov @southerneer

Comments

@mstidham
Copy link

Invisible Mode: User in invisible mode does not have overlay on presence widget

QA TEMPLATE Input
Device Type: iPhone 7 Plus
iOS: 12.0.1
tr Version: 3.9.3
Environment Staging
Codepush: MST3 - #2
Internet Connection Type: WiFi
Users affected? Miranda
User handle: @miranda
Bypass handle?:
Location access type? Always
Does this issue occur on other environments?
Time issue occurred (UTC)

Observed Result:

If user turns on invisible mode the overlay on the presence widget does not appear.

Expected Result:

Overlay should be over presence widget.

Steps to reproduce:

  1. Turn invisible mode on
  2. Return to HS
  3. Presence widget still visible

Related Screenshots/Video Links:

image
@mstidham
Copy link
Author

Also adding that when user turns invisible mode off the presence widget does not update showing the user back in as visitor on locations they are currently in.

@southerneer southerneer self-assigned this Oct 26, 2018
southerneer added a commit that referenced this issue Oct 26, 2018
@southerneer
for #3016
88b2cb5
aksonov added a commit that referenced this issue Oct 27, 2018
@aksonov
Merge pull request #3019 from hippware/3016
c040c0a 
for #3016
@mstidham
Copy link
Author

Verified on Staging Version: 3.9.4

@thescurry
Copy link

@southerneer when the user taps "Turn Off Invisible Mode" it should present a popup that ask "Are you sure you want to turn off invisible mode?", same as if you disable invisible mode through the menu/invisible mode screen.

@aksonov
Copy link
Contributor

aksonov commented Nov 21, 2018

Okey, I will try to finish it

@aksonov aksonov self-assigned this Nov 21, 2018
aksonov added a commit that referenced this issue Nov 21, 2018
@aksonov
DRY, add alert for #3016
9e4f0fd
southerneer added a commit that referenced this issue Nov 21, 2018
@southerneer
Merge pull request #3082 from hippware/3016
b30ce7d 
DRY, add alert for #3016
@mstidham
Copy link
Author

Verified on Staging Version: 3.10.1

irfirl added a commit that referenced this issue Nov 26, 2018
@irfirl
Merge remote-tracking branch 'origin/master' into storybook-UITweaks
a53a9e5 
* origin/master:
  changelog [skip ci]
  bump version to 3.10.1
  changelog [skip ci]
  avoid crash for #3069
  customization for backbuton, other improvements (#3027)
  force visitor refresh for #3071, remove spinner #3043
  changelog [skip ci]
  use question mark as default emoji
  finish up new emoji selector functionality
  remove custom font and introduce BotIcon for existing bots with old icon
  wip
  add "tap to change" message
  WIP: first draft for #3027
  cleanup GraphQLTransport
  move README to root directory
  DRY, add alert for #3016
  add "new" login flow to GraphQLTransport with tests
  make a README
@bengtan
Copy link
Contributor

bengtan commented Jun 20, 2019

@mstidham:

Hmmm ... in light of the recent changes to Invisible Mode (ie. now doing 'client side' invisible mode), I dunno ... is this ticket still applicable? The requirements/specifications have changed since.

@mstidham
Copy link
Author

Verified on 4.14.0 closing ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aksonov aksonov

@southerneer southerneer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bengtan @aksonov @southerneer @thescurry @mstidham