Users incorrectly showing at locations

[mstidham]

Users incorrectly showing at locations

QA TEMPLATE	Input
Device Type:	iPhone 7 Plus
iOS:	12.0.1
tr Version:	3.9.3
Environment	Staging
Codepush:
Internet Connection Type:	WiFi
Users affected?	Miranda
User handle:	@miranda
Bypass handle?:
Location access type?	Always
Does this issue occur on other environments?	Prod
Time issue occurred (UTC)	2018-10-25 6:28 PM

Observed Result:

Issue 1: User Miranda pans to location "500 E Oklahoma Ave" and taps on pin to go to Location Profile. User @don is showing that he is currently at that location (he is at least 20 miles away from this location). I then tap on the avatar to go to the Who's Here List and briefly see Don within the list but it quickly goes away and is replaced with the infinite loader.
Issue 2: Miranda saw that @thescurry left the "Blue Bottle" via notification screen. I tapped on the notification to be taken to the location profile that shows @thescurry is still at that location. Go to the Who's Here screen and have the infinite loader.
Issue 3: Miranda received a push notification that @thescurry left "Pacific Design Center", I tapped on push notification and app loaded and deep linked to the location profile. Location Profile was showing that @thescurry was still at the PDC. Went to Who's Here screen and @thescurry was listed as visitor even though I deep linked from a push that stated he left that location. @thescurry disappeared from the list and was replaced with an infinite loader.

Expected Result:

Location Profile should not show a user at a location if they are not there.

Steps to reproduce:

Issue #1 is not easily reproducible so I will provide steps for Issue #2

1. Go to the notification screen and tap on a notification that shows user left the "location"
2. Location Profile will show user is currently here!
3. Tap on the avatar and go to the Who's Here screen.
4. User appears and then is replaced with an infinite loader.

Related Screenshots/Video Links:

---

Screenshot of user Don showing at a location that is 20 miles away from.

Screenshot of user Scurry showing at a location he is not at and the infinite loader.

[bengtan]

The common thread I see with issues 1,2 and 3 is the infinite spinner.

I've been able to artificially reproduce the spinner and I've spun it out in a separate ticket #3043.

It's gone into a separate ticket because it might not be the only bug causing this issue. Let's fix #3043, and then revisit this one.

[bengtan]

Also ... what I'm thinking is that ... sometimes the app is showing old data. The app thinks there is a visitor at a bot but there is actually none. Then, when it tries to display the visitor list, it encounters #3043.

[aksonov]

@mstidham Could you check?

[mstidham]

I'm no longer seeing the infinite loader however Don is currently stuck at "The Stidham Residence", he has entered/exited several times and is not generating any notifications. His device has not been updated so I will need a bit more time to verify this.

[aksonov]

I guess it could be related with other issues (RNBGL issues, @bengtan ?), this ticket about showing old data (cached) instead of actual as well as infinite spinner. Let's leave one for RNBGL and close all others.

[aksonov]

I meant #2508

[bengtan]

Yes, it could be #2508 creeping up.

I had a look at Don's data points on Staging earlier today. Since the time that the screenshot was posted, Don's app has bee sending location data points. So I figured ... give Miranda some time to disambiguate and/or post some info that will help me to disambiguate.

[mstidham]

Verified on Staging Version: 3.10.1

The reason for Don being stuck is due to me removing the app. All is good!

[mstidham]

Verified on Prod Version: 4.18.0
New ticket created for similar issue