Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash after removing current visited bot #2248

Closed
aksonov opened this issue Apr 27, 2018 · 14 comments
Closed

Crash after removing current visited bot #2248

aksonov opened this issue Apr 27, 2018 · 14 comments
Assignees
Labels

Comments

@aksonov
Copy link
Contributor

aksonov commented Apr 27, 2018

Error in tinyrobot

Error in node_modules/mobx-state-tree/dist/mobx-state-tree.js:1931
[mobx-state-tree] This object has died and is no longer part of a state tree. It cannot be used anymore. The object (of type 'Bot') used to live at '/wocky/bots/storage/98160d3a-4a49-11e8-9473-0a580a02051b'. It is possible to access the last snapshot of this object using 'getSnapshot', or to create a fresh copy using 'clone'. If you want to remove an object from the tree without killing it, use 'detach' instead.

View on Bugsnag

Stacktrace

node_modules/mobx-state-tree/dist/mobx-state-tree.js:1931 - Object

View full stacktrace

Created automatically via Bugsnag

@mstidham
Copy link

I received bugsnag and not sure what caused it but will list the previous actions taken:

  1. Logged out of @miranda account
  2. Did a kill/reload
  3. Logged in bypass account @TestyTester and deleted a bot
  4. Logged out of bypass account and did another kill/reload
  5. App loaded to the signin screen and at that time I received the bugsnag.

@mstidham
Copy link

mstidham commented May 7, 2018

I just received this bugsnag while trying to test ticket #2247. Deleted a bot a received app crash on @TestyTester account.

@zavreb zavreb changed the title Error in node_modules/mobx-state-tree/dist/mobx-state-tree.js:1931 Deleted bot and received bugsnag May 7, 2018
@southerneer
Copy link
Contributor

This doesn't happen on every bot delete, correct?

@zavreb zavreb changed the title Deleted bot and received bugsnag Error in node_modules/mobx-state-tree/dist/mobx-state-tree.js:1931 May 7, 2018
@zavreb
Copy link

zavreb commented May 7, 2018

This doesn't happen on every bot delete, correct?

Returning to previous name due to lack of certainty.

@zavreb
Copy link

zavreb commented May 8, 2018

Needed to test #2247

@mstidham
Copy link

mstidham commented May 8, 2018

@southerneer I just reproduced this on a presence bot that the user is currently a visitor. If you delete the bot from the widget the app crashes. I have not tried this with regular bots but will try that now.

@aksonov aksonov changed the title Error in node_modules/mobx-state-tree/dist/mobx-state-tree.js:1931 Crash after removing current visited bot May 8, 2018
@aksonov aksonov self-assigned this May 8, 2018
@zavreb
Copy link

zavreb commented May 9, 2018

Per @mstidham on #qa, link:

I deleted Ace Lumber instead of Softball and had no issues.

@southerneer
Copy link
Contributor

Then does this mean #2247 is good to go?

@mstidham
Copy link

mstidham commented May 9, 2018

Codepush Verified Staging-Pavel "#2225, #2248, #2244

@mstidham
Copy link

mstidham commented May 10, 2018

Verified on Staging Version: 2.6.3
Although I did not logout of device and log in as another user. Wonder if this is what caused the zombies.

@zavreb
Copy link

zavreb commented May 16, 2018

😍 Verified on Staging Version 2.6.3

@zavreb
Copy link

zavreb commented May 17, 2018

Verified on Prod 2.6.7

@mstidham
Copy link

Verified on Production Version: 2.6.8

@southerneer
Copy link
Contributor

this one popped up again on Prod 2.6.8 today. Bugsnag reports that the app was in the foreground for 2 days (!) before the crash...hopefully an edge case that we can safely ignore.

@zavreb zavreb closed this as completed May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants