GEOFENCE: Presence Functionality Turned Off

[zavreb]

Note: This is different from disabled presence, this is when presence feature is turned off entirely.

Guest disables footprint CTA: Presence feature turned off for Guest:

• Guest disables footprint CTA (now only becoming a subscriber, thus the heart CTA needs to stay ON)
• Guest no longer receives presence related push notifications (arrived/left)
• Who's Here, Visitors CTA no longer displays
• Guest can still see the radius on the Bot Profile

Bot Owner removes Presence: Presence feature turned off for ALL

• Bot Owner toggles "Presence: OFF", the bot has the presence feature turned off after the bot owner taps Saves Changes
• No longer displaying the radius on the Bot Profile
• All Guests become Subcribers only
• All bot guests no longer receives presence related push notifications
• Who's Here, Visitors CTA no longer displays

[aksonov]

Should already work (UI part), did QA checked it?

[zavreb]

Blocked until guests can receive presence shares.

[bengtan]

The relevant server side ticket hippware/wocky#1325 has been deployed to Staging with version 2018.3.21+r9592c13 so I believe this ticket can proceed.

[mstidham]

Bot Owner removes presence:

Radius is still visible on bot profile for bot owner.

Who's Here, Visitors CTA continue to display for guest.

[aksonov]

A radius represents 'geofence' type of the bot. Presence CTA unsubscribes owner from presence notifications but doesn’t change type of the bot. Beng, correct me if I’m wrong... cc @zavreb

…

On 22 Mar 2018, at 20:48, mstidham ***@***.***> wrote: Bot Owner removes presence: Radius is still visible on bot profile for bot owner. <https://user-images.githubusercontent.com/20051373/37794198-cdd7033e-2dde-11e8-9e64-ce724d5d196f.PNG> Who's Here, Visitors CTA continue to display for guest. <https://user-images.githubusercontent.com/20051373/37794437-712b7f92-2ddf-11e8-89b5-3f485b953931.jpeg> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1958 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQpcbKUlzipVKhFUEVY4gECk--bBIAQks5tg__5gaJpZM4ShFo_>.

[aksonov]

Maybe we need to define UI specs more precisely... And we should collect them into wiki, not just various tickets...

[aksonov]

Oh, just read that "Bot Owner removes Presence: Presence feature turned off for ALL", sorry I missed it , but it looks very strange and contradicts with our past discussion - that owner could unsubscribe from own bot and other users still will be able to check others presence...
cc @bengtan

[aksonov]

@mstidham
Okey, I see some misinterpretation here. I see presence switch "See Who's Here" and thought that it is "Presence". Also I see "footprint CTA" and it is NOT "presence" right?

I've just checked and disabled "See Who's Here", and Radius is disappeared for everybody, as expected...

[mstidham]

Thanks @aksonov, the wording is going to be a bit confusing to me for a bit.

[southerneer]

I'm confused too...are we saying this is working according to the original specs in this ticket?

[zavreb]

Wait guys, please hold on this.

[zavreb]

Implementation is correct.

Bot Owner toggles "Presence: OFF", the bot has the presence feature turned off after the bot owner taps Saves Changes

This means that if the user toggles the Geofence feature off it no longer becomes a Geofence bot.

If a owner disables footprint then that means the bot is still a geofence bot, except the owner doesn't receive presence notifications and is unable to see visitors.

Current implementation is correct cc: @mstidham (cc: @aksonov, @southerneer)

[zavreb]

Bug:

User disabled See Who's Here Toggle: OFF, tapped discard changes, however, geofence was still turned off, even tough user tapped discard changes.

• Bot Owner toggles "Presence: OFF", the bot has the presence feature turned off after the bot owner taps Saves Changes

@southerneer / @aksonov is this is a difficult requirement?

[southerneer]

"Discard changes" doesn't apply for any bot changes. That's a separate ticket.

[zavreb]

Ok thanks, going to continue moving this ticket in the flow then.

cc: @thescurry

[mstidham]

Verified on Production Version: 2.6.7