Adjust Message Image Display within Homefeed

[zavreb]

Issue: Currently, images have no cap within the homefeed. These images clutter the homefeed and therefore we would like to adjust the size of them.

Acceptance Criteria:

1. Please adjust how ALL images sent from messages are rendered within the homefeed to match the screenshot below. Per server side limitations, we will only render one image within the homefeed (even if a user sends multiple images)

2. Please see Zeplin link for image dimensions

* Please ignore how the other +2 image renders

3. If user sends multiple images, please display the first/last image (whichever makes implementation easier)

[aksonov]

@zavreb Could you say what is exactly wrong and should be fixed? It is difficult to find all differences from picture, some text representation would be very helpful.

My forecast:

1. Remove white border width = 1 (mock contains zero, right?)
2. Remove "username sent you a message"
3. Add also text message together with picture - it could be a problem because now app sends picture alone, without comment. I believe separate ticket should be created for attaching messages to pictures and clarify flow. Probably we need to change attach function almost completely (with some kind of image preview before sending, etc.).

[zavreb]

@aksonov

Does the zeplin link not help? It's noted on item #2. Important, this ticket specifies on implementing only the one image example (the lion) without the "Have you ever seen lions...".

Your forecast:

1. Yes (please see zeplin link 1.0 #2)
2. Where does it say to remove "username sent you a message"
3. Good point, it is only the image that is to appear (if that were the last message a user sent within messages) <-- does this make sense?

[mstidham]

Looks great

[zavreb]

Can't test bc of homestream issues. Awaiting a homestream fix from the BE (cc @benghippware) where homestream isn't providing the correct timestamps, there seem to be message displaying issues in the homestream.

cc: @thescurry

[mstidham]

Looks great on some images but not on others.

[aksonov]

@mstidham What images don't look OK? I don't understand

[aksonov]

Or do you meant missed notifications?

[mstidham]

I was thinking that the image on the right should be the size of the one on the left on HS.

[aksonov]

Pictures have different orientation. Do you mean it should be cropped??

On 21 Nov 2016, at 15:10, mstidham notifications@github.com wrote:

I was thinking that the image on the right should be the size of the one on the left on HS.
https://cloud.githubusercontent.com/assets/20051373/20485534/9dbc6b86-afc1-11e6-8510-6dc9870d852f.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #155 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/ABQpcck9AYxgUTh59uSLrK1tcmsqGLANks5rAaZTgaJpZM4KuS5a.

[mstidham]

@aksonov I'm really not sure. @zavreb What are your thoughts?

[zavreb]

@aksonov yes it should be centered and cropped for display in the homefeed. The image sizing is meant for both landscape and portrait images.

[benghippware]

My two bits:

The two images have different proportions (ie. landscape vs portrait).

If they should appear as exactly the same size in the home screen, the only way to achieve this is to crop them both to square proportions (ie. same height and width).

[zavreb]

@benghippware what about keeping landscape images as is and portrait images to the square proportions of the landscape's width? 345 x 345 pt

[benghippware]

You'd get different heights (which is what's happening in Miranda's screenshot).

[benghippware]

It wouldn't be as dramatic a difference as if the portrait image wasn't cropped at all.

The portrait images (after cropping) would be slightly "taller" than the landscape images, but not as much. I guess this could be a compromise but I'll leave that up to you.

[zavreb]

Pushing this to the next sprint, will discuss further w/design.

[zavreb]

Closing this ticket. Keeping it as is. cc: @aksonov @thescurry @benghippware