Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BOT PROFILE: Tweak previous "unsubscribe" alert to "unsave" alert #1410

Closed
5 tasks done
zavreb opened this issue Oct 16, 2017 · 6 comments
Closed
5 tasks done

BOT PROFILE: Tweak previous "unsubscribe" alert to "unsave" alert #1410

zavreb opened this issue Oct 16, 2017 · 6 comments
Assignees
@southerneer
Milestone
Sprint #17.1 | Oc...

Comments

@zavreb
Copy link

zavreb commented Oct 16, 2017 •
edited by southerneer
Loading

GOAL: Because we've changed "subscribers" to be saves, we need to adjust our "unsubscribe" alert to fit inline with "saves".

REQs:

  • Change alert wording from Are you sure you want to unsubscribe? to Are you sure you want to remove this from your saved bots?
  • Change the actions from Cancel and Unsubscribeto Cancel and Remove
  • Please maintain red "right option"
  • Please add a mask when this alert appears so that the focus is on the alert
  • Tapping Remove works the same as tapping Unsubscribe (maintain functionality)
  • See here for zeplin link: zpl.io/VO8DWYa
@zavreb zavreb added this to the Sprint #17.1 | Oct 13 - Oct 26 milestone Oct 16, 2017
southerneer pushed a commit that referenced this issue Oct 24, 2017
@prefontaineman1
for #1410
fcc734f
@southerneer southerneer mentioned this issue Oct 24, 2017
Merged
@mstidham
Copy link

Cancel is in blue unlike the grey cancel on the mock. I believe this is due to ios can't be changed so just noting. Verified on Staging

@zavreb
Copy link
Author

zavreb commented Oct 27, 2017

LGTM. Verified on Staging 1.56.3

@irfirl see @mstidham comment pls.

@irfirl
Copy link
Contributor

irfirl commented Oct 27, 2017

Verified on Staging - looks good

@mstidham
Copy link

mstidham commented Nov 1, 2017

Verified on Prod

1 similar comment
@irfirl
Copy link
Contributor

irfirl commented Nov 1, 2017

Verified on Prod

@zavreb
Copy link
Author

zavreb commented Nov 1, 2017

Verified on Prod. Closing ticket.

@zavreb zavreb closed this as completed Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@southerneer southerneer

Labels
None yet
Projects
None yet
Milestone
Sprint #17.1 | Oct 13 - Oct 26
Development

No branches or pull requests
4 participants
@southerneer @irfirl @zavreb @mstidham