Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOT PROFILE: Enable static image of the map behind the bot pin #1405

Closed
5 of 7 tasks
zavreb opened this issue Oct 16, 2017 · 12 comments
Closed
5 of 7 tasks

BOT PROFILE: Enable static image of the map behind the bot pin #1405

zavreb opened this issue Oct 16, 2017 · 12 comments
Assignees

Comments

@zavreb
Copy link

zavreb commented Oct 16, 2017

GOAL: Per user testing and per stakeholder goals we'd like to enable the map background into the Bot Profile so that users can readily tell where a bot is located and also brands as away from feeling like "Instagram"

REQs:

  • Default view for Bot Profiles
  • Please enable a static image of the map at a zoom level of: 10.7 (11 if 10.7 is not possible cc: @irfirl) (not to be confused with the map view of 12)
  • See here for zeplin zpl.io/2yeyWL2
  • When user does not upload a cover image, please display the default cover image
  • Please maintain our existing logic in "randomizing" these default cover image
  • See zeplin link here: zpl.io/V1dlDZ2
  • Enable a hairline width with the 1x1 image being at 172 x 172 pt
  • At the top of the image, please round the corner (don't apply the same for the bottom)

image

image

@zavreb
Copy link
Author

zavreb commented Oct 18, 2017

Added #1407 (closed) into this ticket per discussion.

aksonov pushed a commit that referenced this issue Oct 23, 2017
…thout location metadata (address is used temporary)
@mstidham
Copy link

Codepush Pavel - The bottom of the image is supposed to remain square and not be rounded.

image

@aksonov
Copy link
Contributor

aksonov commented Oct 23, 2017

I don't know how to achieve that. @southerneer maybe you could look. As I see it is possible on android, but not iOS:
https://stackoverflow.com/questions/35341502/how-to-use-border-radius-only-for-1-corner-react-native

@aksonov
Copy link
Contributor

aksonov commented Oct 23, 2017

@aksonov
Copy link
Contributor

aksonov commented Oct 23, 2017

@mstidham, @southerneer Found the solution, please check latest code push now

@mstidham
Copy link

Looks great, codepush verified

@zavreb
Copy link
Author

zavreb commented Oct 23, 2017

LGTM, codepush verified.

@mstidham
Copy link

Verified on Staging

1 similar comment
@irfirl
Copy link
Contributor

irfirl commented Oct 27, 2017

Verified on Staging

@zavreb
Copy link
Author

zavreb commented Oct 27, 2017

Verified on Staging. Pushing ticket to "Verify on Prod"

@mstidham
Copy link

mstidham commented Nov 1, 2017

Verified on Prod

@zavreb
Copy link
Author

zavreb commented Nov 1, 2017

Verified on Prod. Closing ticket.

@zavreb zavreb closed this as completed Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants