App is not deregistering push notifications upon logout

[bengtan]

From poking around in the database (hippware/wocky#1010 (comment)), we can see evidence that the app is not deregistering push notifications upon logout.

This was supposedly fixed in #860 but it appears to still be happening.

[zavreb]

Moving this to S19.

[zavreb]

low priority, being pushed into S19 nonetheless.

[mstidham]

@bengtan to verify (cc: @rz, @scurry)

[zavreb]

Not sure how to check this in le db but would appreciate the info :)

@southerneer, @bengtan

[southerneer]

SELECT u.handle, d.resource, d.token, d.updated_at, d.invalid, d.feedback
FROM users u, devices d
WHERE d.user_id = u.id AND handle='kirkham'

If I run that query before I logout with kirkham I should see x entries and after I logout I should see x-1 entries.

[bengtan]

I'll verify it next week.

[zavreb]

@bengtan update?

[bengtan]

Haven't got around to it yet, sorry. Been working on other stuff.

I'll try to get to it tomorrow.

OTOH, if having this stuck on 'Verify on Prod' is disrupting your workflow, just go ahead and close. I will revisit anyway, and if necessary, I can re-open then.

[bengtan]

Tested but got inconclusive results. Need to do further testing.

[zavreb]

Will keep opened in the interim. Does not interrupt workflow.

[bengtan]

Strange. I tested again on Staging and it's working fine now (across 10-20 test runs of various combinations). I didn't test on Prod but it's good enough for me.

Closing.