HS Optimization Latest Pavel Codepush 08/11

[zavreb]

Per @aksonov from slack:

Implemented various improvements for HS load, reduced number of HS re-renders, avoided double requests, defered bots loading, etc. I could do more optimizations if necessary - like loading bots during home stream loading within one mobx transaction (now they are loaded after and home stream re-renders for each loaded bot), defer conversation list loading, but it will require more time. Btw, maybe server could provide possibility for batch bot loading or include bot details into home stream. Codepushed for testing

[zavreb]

Closing, since this has become a comment for #1085.

Reopening to keep it as an isolated issue.

[zavreb]

Tested with user @BleepBloopBlap on two devices at the same time. Compared both HS views, side by side and noted discrepancies below (cc: @mstidham)

Base 1.43.1	Base 1.43.1 + Codepush Pavel
Initial App Load	Initial App Load
Immediately loads	Immediately loads
A card was pushed down within a few seconds not related to new hf updates	card was already shown
Some cover photo were not displayed for first batch	Cover photos already displayed for first batch
Second batch load showed cover photos	Second batch load flashed in cover photos
Some cover photos never loaded	All cover photos eventually loaded
Batch loads are longer	Batch loads are shorter
Reached an impasse at 199d w/spinning wheel of doom	Reached an impasse at 199d w/spinning wheel of doom
App from background	App from background
works fine	works fine
App kill	App kill
was a bit slower to load	loads fine
many cards are omitted (~5-10)	cards were not omitted relative to base
App kill, fast scroll	App kill, fast scroll
Experiencing jumping around issues (cards being inserted)	Stable experience
Noticed gap between 64d and 98d posts	Noticed gap between 64d and 98d posts
Reached an impasse at 53d w/spinner wheel of doom	Reached an impasse at 98 w/spinner wheel of doom

Conclusion:

Base:

• Batch second load after app kill omits cards relative to Base + Pavel Codepush
• Second batch load works better than second batch load for Pavel Codepush (lazy loading pull)
• Batch loads are longer

Base + Pavel Codepush:

• Initial app load works better than Base
• No jumping around noticed
• Batch loads are shorter
• Lots of cover photos flashing in. v. batch loads from base (where it didnt' happen)

[zavreb]

@mstidham feedback:

Codepush-Pavel
Issue 1
I'm still seeing issue 1.
Initial load is perfect. I see the latest tile at 1 hr
2nd load: I see 3 tiles 3d - 1d - 1hr
3rd load: 2 tiles 3d - 1hr
4th load: 2 tiles 3d - 1hr
See video attached: https://app.box.com/s/581dcca6tpgs9trjse3g03c9wwk0cu0k

Issue 2
I have created a new ticket that I believer relates to Issue #2. Ticket #1092

[mstidham]

Verified on Staging

[zavreb]

Verified on Staging. Pushing ticket to "Verify on Prod"

[mstidham]

Verified on Prod

[irfirl]

Verified on Prod

[zavreb]

Verified on Prod. Closing ticket.