Sync eng/common directory with azure-sdk-tools for PR 2009 (Azure#20672)

* Skip PSModule caching in container jobs

* Add succeeded check to condition

Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

eng/common/pipelines/templates/steps/cache-ps-modules.yml

@@ -3,8 +3,12 @@ steps:
     . ./eng/common/scripts/Helpers/PSModule-Helpers.ps1
     Write-Host "##vso[task.setvariable variable=CachedPSModulePath]$global:CurrentUserModulePath"
   displayName: Set PS Modules Cache Directory
+  # Containers should bake modules into the image to save on pipeline time
+  condition: and(succeeded(), eq(variables['Container'], ''))
 - task: Cache@2
   inputs:
     key: 'PSModulePath | $(CacheSalt) | $(Agent.OS) | $(Build.SourcesDirectory)/eng/common/scripts/Import-AzModules.ps1'
     path: $(CachedPSModulePath)
-  displayName: Cache PS Modules
+  displayName: Cache PS Modules
+  # Containers should bake modules into the image to save on pipeline time
+  condition: and(succeeded(), eq(variables['Container'], ''))