Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/fix cache config #53

Merged
merged 2 commits into from
Mar 14, 2021
Merged

Chore/fix cache config #53

merged 2 commits into from
Mar 14, 2021

Conversation

chr4
Copy link
Contributor

@chr4 chr4 commented Mar 14, 2021

This fixes a typo in the shelly.yaml example. Fixes #52.

Furthermore, I've added a commit to use const from upstream for DefaultExpiration instead of manually setting it to 0.

I think this is cleaner, but I can also remove this commit if it's not wanted. See https://github.com/patrickmn/go-cache/blob/46f407853014144407b6c2ec7ccc76bf67958d93/cache.go#L32

@chr4 chr4 mentioned this pull request Mar 14, 2021
Closed
hikhvar
hikhvar requested changes Mar 14, 2021
View reviewed changes
Copy link
Owner

@hikhvar hikhvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix. Yeah using the cost sentinel value from upstream is much more cleaner an future proof.

@chr4 chr4 force-pushed the chore/fix-cache-config branch from 5ded3b0 to 6ab535e Compare March 14, 2021 12:26
@hikhvar hikhvar merged commit b1504ca into hikhvar:master Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hikhvar hikhvar hikhvar requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Caching doesn't work?
2 participants
@chr4 @hikhvar