Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for TLS client certificates #49

Merged
merged 3 commits into from
Mar 12, 2021
Merged

support for TLS client certificates #49

merged 3 commits into from
Mar 12, 2021

Conversation

weboo
Copy link
Contributor

@weboo weboo commented Mar 12, 2021

No description provided.

hikhvar
hikhvar requested changes Mar 12, 2021
View reviewed changes
Copy link
Owner

@hikhvar hikhvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you in general return an error if the TLS setup is invalid? And please make a non-TLS setup still viable.

@weboo weboo mentioned this pull request Mar 12, 2021
Closed
@weboo weboo requested a review from hikhvar March 12, 2021 13:51
@hikhvar hikhvar merged commit 87310fc into hikhvar:master Mar 12, 2021
@weboo weboo deleted the tls-client-certificates branch March 12, 2021 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hikhvar hikhvar hikhvar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weboo @hikhvar