Changed incorrect port number #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! As mentioned in #17, please change also this line mqtt2prometheus/hack/prometheus.yml Line 30 in 3579483 |
As mqtt2promethius is built from source, it should export 9641:9641 instead of 8002:8002 Fixes issue hikhvar#17
vikramsubramanian
force-pushed
the
master
branch
from
bd3d46f to
f14e2a7
Compare
|
Oops! Looks like I forgot about that. I've made the change now. |
hikhvar
approved these changes
Sep 18, 2020
|
Thx for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mqtt2promethius is built from source,
it should export 9641:9641 instead of 8002:8002
Fixes issue #17