Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented [local] named pipe transport support. #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lor3
Copy link
Contributor

@lor3 lor3 commented Dec 23, 2013

Not sure if you are interested in this, in my tests (Windows 8.1/64-bit) TCP connections were around 50% faster which was a bit of a surprise, but this may not be the case for older Windows versions.

Could be made into an external module if some Scs internals were made public.

Review on Reviewable

@lor3
Copy link
Contributor Author

lor3 commented Jun 25, 2015

@menduz
Copy link

menduz commented Dec 8, 2015

👍🏻

@hikalkan
Copy link
Owner

Hi,

Your effort is valuable. But I also did implemented NamedPipes as communication channel. But saw that it's slower than TCP (especially when using mutexes to control read/write to named pipe). And then I removed it since TCP is more generic and it has no resctriction to be in same computer like named pipes.

So, I think to not include named pipes to SCS. If you really like, you may publish it as a seperated library. So, anyone can add reference to your library and use it in SCS.

Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants