-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: hatchling build system, update workflows #149
Conversation
@nvictus pybbi didn't compile with 3.11 so I haven't included |
Ready for review... |
uses: actions/cache@v3 | ||
with: | ||
path: data/ | ||
key: ${{ runner.os }}-{{ hashFiles('get_test_data.sh') }}-{{ hashFiles('.gitignore') }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
creates a key from the hash to get_test_data.sh
and .gitignore
. Cache is invalidated if either of these change.
pyproject.toml
Outdated
{ name = "Peter Kerpedjiev", email = "pkerpedjiev@gmail.com" }, | ||
] | ||
dependencies = [ | ||
"numpy<=1.23.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cooler < 9.0 relies on np.object
which has been deprecated
pyproject.toml
Outdated
"slugid", | ||
"sortedcontainers", | ||
"nose", | ||
"cooler>=0.8.5, <0.9.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tiles/cooler.py
is not compatible with cooler
v0.9
it might be worth thinking about breaking about the dependencies of clodius so modules can be installed separately in the future. e.g.,
vs.,
|
The linting error yields real errors now for undeclared variables. not sure how to resolve. |
It's a broken function. Let's fix or remove it. |
Description
What was changed in this pull request?
clodius
to ahatching
build system (pyproject.toml-only, nosetup.py
orsetup.cfg
)data/*
(uses hash of.gitignore
andget_test_data.sh
as cache key).flake8
.Why is it necessary?
Some much needed updates to use clodius in modern projects.
Fixes #___
Checklist
black .