Fix t glob #25
Merged
Fix t glob #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
take square-root for the weigths in coherent mappers version advance
added option to replace weights by `1` for the coherent radiation checks
…nd far field added the option to `calculate_spectrum` for weights tweaking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug with physical time axis -- previously the track with different starting iteration had different local time axes which lead to problems with coherent mappers. Currently the global time axis is used for all tracks.
Also have added an option to replace particle weights with
1for a more physical consideration of coherent effects. This should at least partially address the problem presented in #23