Update package.json #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an issue when trying to use this with vite-ssg: ``` [vite-ssg] An internal error occurred. [vite-ssg] Please report an issue, if none already exists: https://github.com/antfu/vite-ssg/issues file:///Users/mykolas/Documents/Projects/the_cheat/.vite-ssg-temp/main.mjs:29 import hljsVuePlugin from "@highlightjs/vue-plugin"; ^^^^^^^^^^^^^ SyntaxError: The requested module '@highlightjs/vue-plugin' does not provide an export named 'default' at ModuleJob._instantiate (node:internal/modules/esm/module_job:127:21) at async ModuleJob.run (node:internal/modules/esm/module_job:193:5) at async Promise.all (index 0) at async ESMLoader.import (node:internal/modules/esm/loader:337:24) at async importModuleDynamicallyWrapper (node:internal/vm/module:437:15) at async build (/Users/mykolas/Documents/Projects/the_cheat/node_modules/.pnpm/vite-ssg@0.17.10_2a1f4eb68d7efe0f1402d91afc414ace/node_modules/vite-ssg/dist/node/cli.cjs:180:87) at async Object.handler (/Users/mykolas/Documents/Projects/the_cheat/node_modules/.pnpm/vite-ssg@0.17.10_2a1f4eb68d7efe0f1402d91afc414ace/node_modules/vite-ssg/dist/node/cli.cjs:314:3) ``` Adding these exports fixes it.
joshgoebel
reviewed
May 17, 2022
package.json
Outdated
| "import": "./dist/highlightjs-vue.esm.min.js", | ||
| "types": "./dist/vue.d.ts" | ||
| }, | ||
| "./*": "./*" |
There was a problem hiding this comment.
As a last resort, package encapsulation can be disabled entirely by creating an export for the root of the package "./*": "./*". This exposes every file in the package at the cost of disabling the encapsulation and potential tooling benefits this provides.
I'm not sure to understand why we need it, @Neophen can you elaborate ?
There was a problem hiding this comment.
Sorry that is not neccasary :D
There was a problem hiding this comment.
Let's remove i& it's not necessary.
smarlhens
suggested changes
May 25, 2022
Co-authored-by: Samuel MARLHENS <11817371+smarlhens@users.noreply.github.com>
joshgoebel
approved these changes
May 25, 2022
mklein994
added a commit
to mklein994/playground-vue
that referenced
this pull request
Oct 28, 2022
This fixes an issue with the dependency resolver not finding the correct file. The commonJS one had an external reference to Vue, which doesn't exist in this project, and was preventing tests with references to `highlight.js` from even running. The ESM version doesn't, so it works if it were specially aliased. Fortunately, this was fixed upstream here: highlightjs/vue-plugin#27
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue when trying to use this with vite-ssg:
Adding these exports fixes it.