-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(chore) Fix build size report #3840
Merged
joshgoebel
merged 19 commits into
highlightjs:main
from
bradleymackey:chore/new-size-report
Aug 17, 2023
Merged
(chore) Fix build size report #3840
joshgoebel
merged 19 commits into
highlightjs:main
from
bradleymackey:chore/new-size-report
Aug 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradleymackey
changed the title
(chore) Fix CDN build size report
(chore) Fix build size report
Aug 13, 2023
Let me know when you're done here. :) Looks pretty awesome. |
@joshgoebel I think it's ready now! A last possible change is whether or not we want only 1 sticky comment that gets edited each time changes are pushed, or a new comment each time (current behaviour). |
I think new comment is good. |
This is the unmerged head, which may be outdated.
joshgoebel
force-pushed
the
chore/new-size-report
branch
from
August 17, 2023 02:53
db1480f
to
2d62846
Compare
joshgoebel
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pull_request
does not have repo write permissions on the repository (so it can't leave a comment on incoming PRs from forks).pull_request_target
does, but is unsafe to use as an event for checking-out untrusted PRs from forks. We should usepull_request
followed byworkflow_run
to post the comment to the PR.pull_request
) step will runnpm run build-cdn
on the base and the PR, then generate the markdown report which is saved as an artifact to the GitHub Actions service. This triggers the second (workflow_run
) step, which reads this report and posts it as a comment (without checking-out or running untrusted code from a fork).workflow_run
will only be run for PRs targeting the base branch (main
).gzip
size for all minified{js,css}
files in thebuild
directory.Changes
Checklist
Added markup teststhis is a CI change onlyCHANGES.md