-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 10 misc chores and small breaking changes #2325
Conversation
8e0f059
to
188a198
Compare
3b0a63f
to
d029109
Compare
Anything else? |
I think I plan to merge this first, so now the other big PR is pending based on this one being approved. :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything makes sense.
Just take care to resolve conflicts with the new build system PR, e. g. there will be no tools/tasks.js
and probably something else.
You don't need to remind me. :-) I'll make sure it all comes together properly. :-) Then once this better foundation is in place I'll try to go back to some smaller changes you'll find easier to review. :-) |
...in favor of only the newer `DOMContentLoaded`
- chore(parser): effectively rename `cpp.js` to `c-like.js` [Josh Goebel][] - chore(parser): create new `c.js` (C), depends on `c-like` now [Josh Goebel][] - chore(parser): create new `cpp.js` (C), depends on `c-like` now [Josh Goebel][] - This will allow us to clean up C/C++ in the future without another breaking change by getting this require change out of the way early. (#2146)
d029109
to
7bd464d
Compare
Should go a long ways towards closing #2273, but not completely.