-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update highcharts-chart.component.ts #73
Conversation
Hi @fclmman Before we could accept the PR we'll need more info about the issue it's related to and what exactly is the "stuff" you mentioned. |
Hi, @KacperMadej, thank for such quick response. What i mentioned is an issue, that can be seen when the application is quite complex, and your page consists of multiple components. It can happen on some enterprise application, where you have huge datagrid and highcharts chart on one page, for example. What i meant by stuff is multiple asynchronous work and eventlisteners that exist inside the highcharts. And as we know it triggers andular's changedetection. So when you track a series in chart with your mouse, highcharts fires lots of point mouseenter events, each of them triggers changedetection, which is really slowing down a huge app. To prevent it we can run highcharts code outside of zone, and prevent multiple changedetections. |
Thank you for all the information. |
@KacperMadej well, you were right, no need in timeout here, updated the pull request |
I had more time run more tests. The idea is interesting and solution for the problem works. It's possible to still use We'll need to prepare some documentation for the new feature. |
Well, if you dont mind i can provide optional runotside, so that current behaviour will stay as default |
Added _zone.runOutsideAngular for highcharts stuff, as it hardly affects application performance due to multiple eventListeners inside highcharts itself