Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for v.1.3.2 #85

Merged
merged 4 commits into from
Aug 10, 2023
Merged

PR for v.1.3.2 #85

merged 4 commits into from
Aug 10, 2023

Conversation

hcpchris
Copy link
Collaborator

  • BUGFIX: Fixed incorrect handling when defining a new Exporting.buttons context button under a different key name than contextButton. (Closes Exporting buttons get dropped #84 )

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #85 (2595ea9) into master (0280157) will decrease coverage by 0.18%.
Report is 1 commits behind head on master.
The diff coverage is 21.25%.

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
- Coverage   90.50%   90.32%   -0.18%     
==========================================
  Files         206      206              
  Lines       27854    27932      +78     
  Branches     1889     1922      +33     
==========================================
+ Hits        25208    25229      +21     
- Misses       1932     1982      +50     
- Partials      714      721       +7     
Files Changed Coverage Δ
highcharts_core/metaclasses.py 60.21% <20.25%> (-6.55%) ⬇️
highcharts_core/utility_classes/buttons.py 84.88% <100.00%> (ø)

@hcpchris hcpchris merged commit 76d95e5 into master Aug 10, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exporting buttons get dropped
1 participant